copy_file allows directories as well #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
copy_directory
branch
4 times, most recently
from
4e86ba4 to
bbd442b
Compare
alexeagle
force-pushed
the
copy_directory
branch
from
bbd442b to
437b878
Compare
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 10, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets a tsc action run with just four inputs: [a.ts, bazel-out/host/bin/external/npm_typescript-3.5.3/out, external/bazel_tools/tools/genrule/genrule-setup.sh, external/node16_linux_amd64/bin/nodejs/bin/node] This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 10, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets a tsc action run with just four inputs: [a.ts, bazel-out/host/bin/external/npm_typescript-3.5.3/out, external/bazel_tools/tools/genrule/genrule-setup.sh, external/node16_linux_amd64/bin/nodejs/bin/node] This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 11, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets a tsc action run with just four inputs: [a.ts, bazel-out/host/bin/external/npm_typescript-3.5.3/out, external/bazel_tools/tools/genrule/genrule-setup.sh, external/node16_linux_amd64/bin/nodejs/bin/node] This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 11, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets an action run with minimal inputs. This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 11, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets an action run with minimal inputs. This is obviously not ergonomic for users yet, just a step in the right direction.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Oct 11, 2021
bazelbuild/bazel-skylib#323 is patched into our vendored copy of copy_file rule. That lets an action run with minimal inputs. This is obviously not ergonomic for users yet, just a step in the right direction.
|
@brandjon @tetromino do you have any feedback on this PR? I believe this will help unblock using rules_nodejs with remote build execution, which would be really nice to see! |
|
Ping! Is anyone triaging PRs in this repo? |
tetromino
requested changes
Jan 10, 2022
| # https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/copy | ||
| # https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/xcopy | ||
| if dst.is_directory: | ||
| cmd_tmpl = "@xcopy \"%s\" \"%s\\\" /V /E /H /Y /Q >NUL" |
There was a problem hiding this comment.
Why use /v for xcopy, but not for copy?
Why delete the destination directory in the bash version, but not in the Windows version?
tetromino
requested changes
Jan 10, 2022
There was a problem hiding this comment.
Overall - looks good; thank you for the patch!
However, I would prefer a separate copy_directory rule: less confusing name (files aren't directories), no confusing interaction between is_directory and allow_symlinks flags, more noticeable documentation of -DBAZEL_TRACK_SOURCE_DIRECTORIES.
The one new test is insufficient. Scenarios we'd probably want to test:
- copying an empty directory
- copying a directory whose content includes a symlink
- copying a directory to a location which is an existing file
- copying a directory to a location which is an existing directory
Merged
|
replaced by #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322