feat: bzlmod setup #385
Merged
feat: bzlmod setup #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates MODULE.bazel and WORKSPACE.bzlmod files to enable bazel-skylib to work with the `--experimental_enable_bzlmod` flag. rules_go has been updated as the previously used version is not available in the BCR. stardoc has been updated due to a strange issue with Bzlmod enabled that caused the `diff_test` and `unittest` docs to be generated without any contents that was magically fixed upon updating.
nickgooding
requested review from
brandjon,
tetromino,
comius,
hvadehra and
c-mita
as code owners
tetromino
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Thanks for doing this!
The only issue is that we'd need to adapt MODULE.bazel to work with bazel_skylib's distribution tarball: we strip out all build-only dependencies and the gazelle extension (which is still experimental) to build the release tarball - see distribution/BUILD.
I think the best way to do that would be to cut everything below the platforms dep out of MODULE.bazel and put the result in the //:distribution filegroup.
I could make those changes myself, fwiw.
tetromino
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates MODULE.bazel and WORKSPACE.bzlmod files to enable bazel-skylib
to work with the
--experimental_enable_bzlmodflag.rules_go has been updated as the previously used version is not
available in the BCR.
stardoc has been updated due to a strange issue with Bzlmod enabled that
caused the
diff_testandunittestdocs to be generated without anycontents that was magically fixed upon updating.
bazelbuild/bazel-central-registry#124