Add gazelle plugin to CI and distribution mechanism #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have 3 versions: the tarball version (version.bzl), the skylib module version (MODULE.bazel), and the gazelle plugin module version (gazelle/MODULE.bazel)
…ilegroup for all tarballs
tetromino
requested review from
achew22,
brandjon,
comius and
c-mita
as code owners
|
Note: as a followup, I will try to see if we can clean up distro BUILD files to not include distro-only targets. I think this is feasible by updating to a newer version of rules_pkg, but the change is big enough that it would be best done as a separate followup PR. |
|
This LGTM. Obviously gotta fixup CI but conceptually this seems like the right direction. Thanks @tetromino! |
brandjon
approved these changes
Jan 19, 2023
Needed to allow building/testing gazelle plugin from bazelci and generating release tarballs when in bzlmod mode. Note that the local_path_override will be stripped out in the tarball release, so users of stable skylib releases will not be affected. Users of a live/unreleased version of skylib who depend on it via git_override will need to add a patch to remove or comment out the local_path_override. I expect the number of such users to be tiny, but I have added a comment in MODULE.bazel to guide them.
Needed to cleanly strip ./external/bazel_skylib_gazelle_plugin~* dir prefixes in the tarball. Also allows us to clean up fixed target name vs. versioned tarball file name without needing aliases. Note that we are using 0.7.0 since 0.8.0 is not yet in BCR.
Provide a patch file that users can use in their git_override
|
This module also needs to be added to the Bazel Central Registry in order to use it - @tetromino is that on your list? Want a PR for it? |
|
@alexeagle - yes, it's my next todo; I just need to generate the tarball |
|
I guess it's a wider discussion, but I think we could chat about distribution of the entire repo instead, it's tremendously simpler. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #400, the gazelle plugin has been cleanly separated out into its own bazel workspace, which will soon finally allow us to mark it stable. But this means:
bazel build //...no longer includes the plugin;