Avoid building build_test deps unnecessarily #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested review from
brandjon,
tetromino,
comius and
c-mita
as code owners
tetromino
approved these changes
May 24, 2023
|
Thank you! |
|
@tetromino would it be possible to also get a new release after this change? |
|
@tetromino friendly ping 😅 |
Draft PR: #451 (Note we also may need to fix some sort of stardoc-related weirdness with bazel at head to unblock ci.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where I had a
build_testthat was only compatible with a particular platform. I had annotated the target withtarget_compatible_withbut continued to get builds on the incompatible platform. This came down to mybazel test //...invocation picking up the{name}_{idx}__depstargets and building the dependency anyway. This change updates these targets to account for newer common attributes and tags them as manual so they're only built when the user facing test target is built.