Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that fail between a new Bazel release and toolchain configs coming out #925

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Disable tests that fail between a new Bazel release and toolchain configs coming out #925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b034028
Disable rbe_autoconfig tests that fail with Bazel releases
smukherj1 Jan 22, 2021
7114f85
Merge remote-tracking branch 'upstream/master' into configs
smukherj1 Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions tests/rbe_repo/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,24 +793,25 @@ file_test(
# tests that use rbe_autoconf_custom_toolchain_config_suite_spec_export
# validate it generates configs when a custom versions.bzl
# file is used.
sh_test(
name = "rbe_autoconf_custom_toolchain_config_suite_spec_export_test",
srcs = [":rbe_autoconf_output_base_config_dir_checks.sh"],
args = [
"$(location @rbe_autoconf_custom_toolchain_config_suite_spec_export//test:empty)",
"rbe-test-output/config/rbe_autoconf_custom_toolchain_config_suite_spec_export",
"test_config_dir",
_ubuntu1604_bazel,
"assert_output_base_cc_confs",
"assert_output_base_java_confs",
"assert_output_base_platform_confs",
],
data = [
":rbe_autoconf_checks.sh",
"@rbe_autoconf_custom_toolchain_config_suite_spec_export//test:empty",
"@rbe_autoconf_custom_toolchain_config_suite_spec_export//test:exported_testdata",
],
)
# Fails whenever a new Bazel version is out but configs aren't out
# sh_test(
# name = "rbe_autoconf_custom_toolchain_config_suite_spec_export_test",
# srcs = [":rbe_autoconf_output_base_config_dir_checks.sh"],
# args = [
# "$(location @rbe_autoconf_custom_toolchain_config_suite_spec_export//test:empty)",
# "rbe-test-output/config/rbe_autoconf_custom_toolchain_config_suite_spec_export",
# "test_config_dir",
# _ubuntu1604_bazel,
# "assert_output_base_cc_confs",
# "assert_output_base_java_confs",
# "assert_output_base_platform_confs",
# ],
# data = [
# ":rbe_autoconf_checks.sh",
# "@rbe_autoconf_custom_toolchain_config_suite_spec_export//test:empty",
# "@rbe_autoconf_custom_toolchain_config_suite_spec_export//test:exported_testdata",
# ],
#)

sh_test(
name = "rbe_autoconf_custom_toolchain_config_suite_spec_export_external_repo_test",
Expand All @@ -832,24 +833,25 @@ sh_test(
# tests that use rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions
# validate it generates configs when a blank versions.bzl
# file is used.
sh_test(
name = "rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions_test",
srcs = [":rbe_autoconf_output_base_config_dir_checks.sh"],
args = [
"$(location @rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:empty)",
"rbe-test-output/config/rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions",
"default_toolchain_config_spec_name",
_ubuntu1604_bazel,
"assert_output_base_cc_confs",
"assert_output_base_java_confs",
"assert_output_base_platform_confs",
],
data = [
":rbe_autoconf_checks.sh",
"@rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:empty",
"@rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:exported_testdata",
],
)
# Fails whenever a new Bazel version is out but configs aren't out
#sh_test(
# name = "rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions_test",
# srcs = [":rbe_autoconf_output_base_config_dir_checks.sh"],
# args = [
# "$(location @rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:empty)",
# "rbe-test-output/config/rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions",
# "default_toolchain_config_spec_name",
# _ubuntu1604_bazel,
# "assert_output_base_cc_confs",
# "assert_output_base_java_confs",
# "assert_output_base_platform_confs",
# ],
# data = [
# ":rbe_autoconf_checks.sh",
# "@rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:empty",
# "@rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions//test:exported_testdata",
# ],
#)

sh_test(
name = "rbe_autoconf_custom_toolchain_config_suite_spec_blank_versions_external_repo_test",
Expand Down