Update max path length to be 256 (MAX_PATH - 4)

bazelbuild · Feb 19, 2021 · 0ee857c · 0ee857c
1 parent f6519c1
commit 0ee857c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/native/windows/util.cc b/src/main/native/windows/util.cc
@@ -195,8 +195,8 @@ static bool Contains(const wstring& s, const WCHAR* substr) {
 }
 
 wstring AsShortPath(wstring path, wstring* result) {
-  // Using MAX_PATH - 2 instead of MAX_PATH to fix https://github.com/bazelbuild/bazel/issues/12310
-  static const size_t kMaxPath = MAX_PATH - 2;
+  // Using MAX_PATH - 4 (256) instead of MAX_PATH to fix https://github.com/bazelbuild/bazel/issues/12310
+  static const size_t kMaxPath = MAX_PATH - 4;
 
   if (path.empty()) {
     result->clear();

diff --git a/src/test/native/windows/util_test.cc b/src/test/native/windows/util_test.cc
@@ -39,8 +39,8 @@ using std::unique_ptr;
 using std::wstring;
 
 static const wstring kUncPrefix = wstring(L"\\\\?\\");
-// Using MAX_PATH - 2 instead of MAX_PATH to fix https://github.com/bazelbuild/bazel/issues/12310
-static const size_t kMaxPath = MAX_PATH - 2;
+// Using MAX_PATH - 4 instead of MAX_PATH to fix https://github.com/bazelbuild/bazel/issues/12310
+static const size_t kMaxPath = MAX_PATH - 4;
 
 // Retrieves TEST_TMPDIR as a shortened path. Result won't have a "\\?\" prefix.
 static void GetShortTempDir(wstring* result) {