Flip the default value of the --legacy_important_outputs flag to `f…

…alse`. Fixes #14353 RELNOTES[INC]: --legacy_important_outputs is flipped to false. See #14353 for details PiperOrigin-RevId: 673122098 Change-Id: Ic9074406ebb7f9ac11be19afc8555aba0f40db60
bazelbuild · Sep 10, 2024 · 241c21d · 241c21d
1 parent aed6a40
commit 241c21d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventProtocolOptions.java b/src/main/java/com/google/devtools/build/lib/buildeventstream/BuildEventProtocolOptions.java
@@ -35,12 +35,12 @@ public class BuildEventProtocolOptions extends OptionsBase {
 
   @Option(
       name = "legacy_important_outputs",
-      defaultValue = "true",
+      defaultValue = "false",
       documentationCategory = OptionDocumentationCategory.LOGGING,
       effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
       help =
           "Use this to suppress generation of the legacy important_outputs field in the "
-              + "TargetComplete event. important_outputs are required for Bazel to ResultStore "
+              + "TargetComplete event. important_outputs are required for Bazel to ResultStore/BTX "
               + "integration.")
   public boolean legacyImportantOutputs;
 

diff --git a/src/test/shell/bazel/bazel_coverage_cc_test_gcc.sh b/src/test/shell/bazel/bazel_coverage_cc_test_gcc.sh
@@ -109,7 +109,8 @@ end_of_record"
 
   # Verify that this is also true for cached coverage actions.
   bazel coverage  --test_output=all \
-      --build_event_text_file="${BEP}" //:t \
+      --build_event_text_file="${BEP}" \
+      --legacy_important_outputs //:t \
       &>"$TEST_log" || fail "Coverage for //:t failed"
   expect_log '//:t.*cached'
   # Verify the files are reported correctly in the build event protocol.