-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Automated rollback of commit af004d1.
*** Reason for rollback *** Breaks many targets in the depot that use the native python rules. *** Original change description *** Remove Python native rule classes and py_runtime PiperOrigin-RevId: 682373910 Change-Id: Ib874b62ff5f3fbf0899a6990d970b04b87dd9d93
- Loading branch information
1 parent
ef1a21f
commit 41507df
Showing
27 changed files
with
1,257 additions
and
225 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryRule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| // Copyright 2014 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.devtools.build.lib.bazel.rules.python; | ||
|
|
||
|
|
||
| import com.google.devtools.build.lib.analysis.BaseRuleClasses; | ||
| import com.google.devtools.build.lib.analysis.RuleDefinition; | ||
| import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment; | ||
| import com.google.devtools.build.lib.bazel.rules.python.BazelPyRuleClasses.PyBinaryBaseRule; | ||
| import com.google.devtools.build.lib.packages.RuleClass; | ||
|
|
||
| /** | ||
| * Rule definition for the {@code py_binary} rule. | ||
| */ | ||
| public final class BazelPyBinaryRule implements RuleDefinition { | ||
| @Override | ||
| public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env) { | ||
| /* <!-- #BLAZE_RULE(py_binary).NAME --> | ||
| <br/>If <code>main</code> is unspecified, this should be the same as the name | ||
| of the source file that is the main entry point of the application, | ||
| minus the extension. For example, if your entry point is called | ||
| <code>main.py</code>, then your name should be <code>main</code>. | ||
| <!-- #END_BLAZE_RULE.NAME --> */ | ||
| return builder | ||
| .build(); | ||
| } | ||
|
|
||
| @Override | ||
| public Metadata getMetadata() { | ||
| return RuleDefinition.Metadata.builder() | ||
| .name("py_binary") | ||
| .ancestors(PyBinaryBaseRule.class, BaseRuleClasses.BinaryBaseRule.class) | ||
| .factoryClass(BaseRuleClasses.EmptyRuleConfiguredTargetFactory.class) | ||
| .build(); | ||
| } | ||
| } | ||
|
|
||
| /*<!-- #BLAZE_RULE (NAME = py_binary, TYPE = BINARY, FAMILY = Python) --> | ||
| <p> | ||
| A <code>py_binary</code> is an executable Python program consisting | ||
| of a collection of <code>.py</code> source files (possibly belonging | ||
| to other <code>py_library</code> rules), a <code>*.runfiles</code> | ||
| directory tree containing all the code and data needed by the | ||
| program at run-time, and a stub script that starts up the program with | ||
| the correct initial environment and data. | ||
| </p> | ||
| <h4 id="py_binary_examples">Examples</h4> | ||
| <pre class="code"> | ||
| py_binary( | ||
| name = "foo", | ||
| srcs = ["foo.py"], | ||
| data = [":transform"], # a cc_binary which we invoke at run time | ||
| deps = [ | ||
| ":foolib", # a py_library | ||
| ], | ||
| ) | ||
| </pre> | ||
| <p>If you want to run a <code>py_binary</code> from within another binary or | ||
| test (for example, running a python binary to set up some mock resource from | ||
| within a java_test) then the correct approach is to make the other binary or | ||
| test depend on the <code>py_binary</code> in its data section. The other | ||
| binary can then locate the <code>py_binary</code> relative to the source | ||
| directory. | ||
| </p> | ||
| <pre class="code"> | ||
| py_binary( | ||
| name = "test_main", | ||
| srcs = ["test_main.py"], | ||
| deps = [":testing"], | ||
| ) | ||
| java_library( | ||
| name = "testing", | ||
| srcs = glob(["*.java"]), | ||
| data = [":test_main"] | ||
| ) | ||
| </pre> | ||
| <!-- #END_BLAZE_RULE -->*/ |
60 changes: 60 additions & 0 deletions
60
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyLibraryRule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Copyright 2014 The Bazel Authors. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.devtools.build.lib.bazel.rules.python; | ||
|
|
||
| import static com.google.devtools.build.lib.packages.Attribute.attr; | ||
| import static com.google.devtools.build.lib.packages.BuildType.LABEL_LIST; | ||
|
|
||
| import com.google.devtools.build.lib.analysis.BaseRuleClasses; | ||
| import com.google.devtools.build.lib.analysis.RuleDefinition; | ||
| import com.google.devtools.build.lib.analysis.RuleDefinitionEnvironment; | ||
| import com.google.devtools.build.lib.bazel.rules.python.BazelPyRuleClasses.PyBaseRule; | ||
| import com.google.devtools.build.lib.packages.RuleClass; | ||
| import com.google.devtools.build.lib.rules.python.PyRuleClasses; | ||
| import com.google.devtools.build.lib.rules.python.PythonConfiguration; | ||
|
|
||
| /** | ||
| * Rule definition for the {@code py_library} rule. | ||
| */ | ||
| public final class BazelPyLibraryRule implements RuleDefinition { | ||
| @Override | ||
| public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env) { | ||
| return builder | ||
| .requiresConfigurationFragments(PythonConfiguration.class) | ||
|
|
||
| /* <!-- #BLAZE_RULE(py_library).ATTRIBUTE(srcs) --> | ||
| The list of source (<code>.py</code>) files that are processed to create the target. | ||
| This includes all your checked-in code and any generated source files. | ||
| <!-- #END_BLAZE_RULE.ATTRIBUTE --> */ | ||
| .add( | ||
| attr("srcs", LABEL_LIST) | ||
| .direct_compile_time_input() | ||
| .allowedFileTypes(PyRuleClasses.PYTHON_SOURCE)) | ||
| .build(); | ||
| } | ||
|
|
||
| @Override | ||
| public Metadata getMetadata() { | ||
| return RuleDefinition.Metadata.builder() | ||
| .name("py_library") | ||
| .ancestors(PyBaseRule.class) | ||
| .factoryClass(BaseRuleClasses.EmptyRuleConfiguredTargetFactory.class) | ||
| .build(); | ||
| } | ||
| } | ||
|
|
||
| /*<!-- #BLAZE_RULE (NAME = py_library, TYPE = LIBRARY, FAMILY = Python) --> | ||
| <!-- #END_BLAZE_RULE -->*/ |
Oops, something went wrong.