Update threshold for long path shortening to be MAX_PATH - 2

bazelbuild · Feb 2, 2021 · 5dd71ae · 5dd71ae
1 parent bb6af8b
commit 5dd71ae
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/native/windows/util.cc b/src/main/native/windows/util.cc
@@ -212,7 +212,8 @@ wstring AsShortPath(wstring path, wstring* result) {
     return MakeErrorMessage(WSTR(__FILE__), __LINE__, L"AsShortPath", path,
                             L"path is not normalized");
   }
-  if (path.size() >= MAX_PATH && !HasSeparator(path)) {
+  // Comparing to MAX_PATH - 2 to fix https://github.com/bazelbuild/bazel/issues/12310
+  if (path.size() >= MAX_PATH - 2 && !HasSeparator(path)) {
     return MakeErrorMessage(WSTR(__FILE__), __LINE__, L"AsShortPath", path,
                             L"path is just a file name but too long");
   }
@@ -225,7 +226,8 @@ wstring AsShortPath(wstring path, wstring* result) {
 
   std::replace(path.begin(), path.end(), '/', '\\');
   // Fast-track: the path is already short.
-  if (path.size() < MAX_PATH) {
+  // Comparing to MAX_PATH - 2 to fix https://github.com/bazelbuild/bazel/issues/12310
+  if (path.size() < MAX_PATH - 2) {
     *result = path;
     return L"";
   }