Add more test cases.

bazelbuild · Feb 13, 2019 · 6cd6294 · 6cd6294
1 parent 915111c
commit 6cd6294
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/tools/launcher/util/launcher_util_test.cc b/src/tools/launcher/util/launcher_util_test.cc
@@ -258,10 +258,13 @@ TEST_F(LaunchUtilTest, WindowsEscapeArgTest) {
     // - second: expected WindowsEscapeArg-encoded string
     {L"foo", L"foo"},
     {L"", L"\"\""},
+    {L" ", L"\" \""},
     {L"foo\\bar", L"foo\\bar"},
     {L"C:\\foo\\bar\\", L"C:\\foo\\bar\\"},
     // TODO(laszlocsomor): fix WindowsEscapeArg to use correct escaping
-    // semantics (not Bash semantics) and add more tests.
+    // semantics (not Bash semantics) and add more tests. The example below is
+    // escaped incorrectly. 
+    // {L"C:\\foo bar\\", L"\"C:\\foo bar\\\""},
   });
 }