Skip to content

Commit

Permalink
Fix #2958: Installer should not overwrite bazelrc
Browse files Browse the repository at this point in the history
Closes #2959.
Ping #2692 for cherry-picking into Bazel 0.5.0.

PiperOrigin-RevId: 155357560
  • Loading branch information
philwo authored and kchodorow committed May 8, 2017
1 parent 0cf3821 commit 7205611
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions scripts/packages/template_bin.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,25 +41,20 @@ usage() {
echo " --prefix=/some/path set the prefix path (default=/usr/local)." >&2
echo " --bin= set the binary folder path (default=%prefix%/bin)." >&2
echo " --base= set the base install path (default=%prefix%/lib/bazel)." >&2
echo " --bazelrc= set the path to bazelrc (default=/etc/bazel.bazelrc)." >&2
echo " --user configure for user install, expands to:" >&2
echo ' --bin=$HOME/bin --base=$HOME/.bazel --bazelrc=$HOME/.bazelrc' >&2
echo ' --bin=$HOME/bin --base=$HOME/.bazel' >&2
exit 1
}

prefix="/usr/local"
bin="%prefix%/bin"
base="%prefix%/lib/bazel"
bazelrc="/etc/bazel.bazelrc"

for opt in "${@}"; do
case $opt in
--prefix=*)
prefix="$(echo "$opt" | cut -d '=' -f 2-)"
;;
--bazelrc=*)
bazelrc="$(echo "$opt" | cut -d '=' -f 2-)"
;;
--bin=*)
bin="$(echo "$opt" | cut -d '=' -f 2-)"
;;
Expand All @@ -69,7 +64,6 @@ for opt in "${@}"; do
--user)
bin="$HOME/bin"
base="$HOME/.bazel"
bazelrc="$HOME/.bazelrc"
;;
*)
usage
Expand All @@ -79,7 +73,6 @@ done

bin="${bin//%prefix%/${prefix}}"
base="${base//%prefix%/${prefix}}"
bazelrc="${bazelrc//%prefix%/${prefix}}"

test_write() {
local file="$1"
Expand Down Expand Up @@ -133,7 +126,6 @@ fi
# Test for write access
test_write "${bin}"
test_write "${base}"
test_write "${bazelrc}"

# Do the actual installation
echo -n "Uncompressing."
Expand All @@ -159,17 +151,7 @@ echo -n .
ln -s "${base}/bin/bazel" "${bin}/bazel"
echo -n .

if [ -f "${bazelrc}" ]; then
echo
echo "${bazelrc} already exists, moving it to ${bazelrc}.bak."
mv "${bazelrc}" "${bazelrc}.bak"
fi

# Not necessary, but this way it matches the Debian package.
touch "${bazelrc}"
if [ "${UID}" -eq 0 ]; then
chmod 0644 "${bazelrc}"
else
if [ "${UID}" -ne 0 ]; then
# Uncompress the bazel base install for faster startup time
"${bin}/bazel" help >/dev/null
fi
Expand Down

0 comments on commit 7205611

Please sign in to comment.