-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
With Xcode 16, `upb` fails its own `-Werror` check due to using Clang extensions. Closes #23667. PiperOrigin-RevId: 676957876 Change-Id: I8e038b5f879077fefdb5811aff6ae5f56fb4f762
- Loading branch information
1 parent
e70af32
commit 72b0abc
Showing
3 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
diff --git a/bazel/upb_proto_library.bzl b/bazel/upb_proto_library.bzl | ||
--- a/bazel/build_defs.bzl | ||
+++ b/bazel/build_defs.bzl | ||
@@ -34,13 +34,13 @@ | ||
_DEFAULT_CPPOPTS.extend([ | ||
"-Wextra", | ||
# "-Wshorten-64-to-32", # not in GCC (and my Kokoro images doesn't have Clang) | ||
- "-Werror", | ||
+ # "-Werror", | ||
"-Wno-long-long", | ||
]) | ||
_DEFAULT_COPTS.extend([ | ||
"-std=c99", | ||
"-pedantic", | ||
- "-Werror=pedantic", | ||
+ # "-Werror=pedantic", | ||
"-Wall", | ||
"-Wstrict-prototypes", | ||
# GCC (at least) emits spurious warnings for this that cannot be fixed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ filegroup( | |
|
||
exports_files([ | ||
"00_remove_toolchain_transition.patch", | ||
"01_remove_werror.patch", | ||
]) |