-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Add support for Windows
linkstatic
computed default
This uses the same technique as `cc_binary` with/without aspects. Essentially we are declaring two rules named cc_test with different private attribute defaults. This is primarily done this way to hide the implementation details of computed defaults until something like [bazel/issues/14434](#14434) is implemented. NOTE: When `cc_test` written in Starlark is made the default, this _will_ introduce a behavior change -- notably that we will default linkstatic based on whether we are _targeting_ Windows, not whether the host Platform is Windows (as is done today). The latter heuristic may have been the best available option before Platforms, but it does not match the actual intent. PiperOrigin-RevId: 441472088
- Loading branch information
1 parent
591dcc4
commit 8ba5eed
Showing
3 changed files
with
27 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters