Skip to content

Commit

Permalink
add dependency_file_feature on macos features
Browse files Browse the repository at this point in the history
This patch add `dependency_file_feature` to features when OS is macos.

the feature `dependency_file_feature` added by default through `CppActionConfigs.java getLegacyFeatures`

https://github.com/bazelbuild/bazel/blob/0dbfaccaf5bee5ea7f11c01db1fc0cd1ca7f3810/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java#L93-L117

## Background

I modified `tools/cpp/unix_cc_toolchain_config.bzl` and found `dependency_file` not work on MacOS when testing #19940 with new action name `c++20-deps-scanning` and `c++20-module-compile`. After adding `dependency_file_feature` to features, it works.

cc @comius

Closes #22717.

PiperOrigin-RevId: 643345857
Change-Id: I50210592edd1082e2328c7e4ab68bd0c76087aaa
  • Loading branch information
PikachuHyA authored and copybara-github committed Jun 14, 2024
1 parent a06abca commit a212e4f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/cpp/unix_cc_toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1581,6 +1581,7 @@ def _impl(ctx):
cpp_modules_feature,
macos_minimum_os_feature,
macos_default_link_flags_feature,
dependency_file_feature,
libtool_feature,
archiver_flags_feature,
asan_feature,
Expand Down

0 comments on commit a212e4f

Please sign in to comment.