Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error prone version to 2.4.0 #11272

Closed
davido opened this issue May 1, 2020 · 5 comments
Closed

Update error prone version to 2.4.0 #11272

davido opened this issue May 1, 2020 · 5 comments
Labels
team-Rules-Java Issues for Java rules untriaged

Comments

@davido
Copy link
Contributor

davido commented May 1, 2020 •
edited
Loading

Last EP upgrade attempt to 2.3.3 was reverted to RefersToDaggerCodegen breakage in rules_kotlin: [1],[2].

This is a feature request to update EP version to 2.3.4.

It turns out, that with EP 2.3.4 there are at least two breakages:

  • rule_closure: [3]
  • rules_kotlin: [4]

[1] #10023
[2] d990746
[3] bazelbuild/rules_closure#483
[4] bazelbuild/rules_kotlin#321
@davido davido mentioned this issue May 1, 2020
Closed
@jin jin added team-Rules-Java Issues for Java rules untriaged labels May 3, 2020
@davido
Copy link
Contributor Author

davido commented May 8, 2020

Fix for rules_kotlin is here: [1]. Fix for rules_closure is here: [2].

[1] bazelbuild/rules_kotlin#320
[2] bazelbuild/rules_closure#484

@davido davido mentioned this issue May 8, 2020
Closed
@meisterT
Copy link
Member

For feature requests like this it would be nice to include a reason for the upgrade.

@davido
Copy link
Contributor Author

davido commented May 13, 2020 •
edited
Loading

For feature requests like this it would be nice to include a reason for the upgrade.

Latest EP releases added bunch of new and shiny bug pattern checks to increase code quality. Bazel eco-system would like to benefit from these enhancements.

Beside that, upgrade to EP 2.3.3 was already attempted by Bazel team: [1] but got reverted: [2], because of the missing dependency on javax.annotation in rules_kotlin. I fixed it though, and my PR: [3] was already merged.

The only known issue is similar breakage in rules_closure that I fixed as well, but the corresponding PR is still pending for approval: [4].

[1] #9372
[2] #10023
[3] bazelbuild/rules_kotlin#320
[4] bazelbuild/rules_closure#484

davido added a commit to davido/bazel that referenced this issue May 14, 2020
@davido
Update error prone version to 2.3.4
9734be0 
Fixes bazelbuild#11272 (first attempt that was reverted: bazelbuild#9286).
This was referenced May 15, 2020
Closed
Open
davido added a commit to davido/bazel that referenced this issue May 17, 2020
@davido
Bump EP version to 2.3.5-SNAPSHOT
9a88ef6 
Fixes: bazelbuild#11272.

This updates error prone to 2.3.5 SNAPSHOT and includes demotion of
breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warnings checks, this upgrade is backwards compatible and must not be
protected with new option --incompatible_use_error_prone_2.3.5_version.

Additional library is needed: threeten-extra-1.5.0.

Also bump guava version to 27.1-jre and add transitive dependency
failureaccess-1.0.1.
davido added a commit to davido/bazel that referenced this issue May 17, 2020
@davido
Update error prone version to 2.3.4
cbfdeed 
Fixes bazelbuild#11272 (first attempt that was reverted: bazelbuild#9286).
davido added a commit to davido/bazel that referenced this issue May 18, 2020
@davido
Bump error prone version to 2.3.5-SNAPSHOT
2959c1f 
Fixes: bazelbuild#11272.

This change updates error prone to 2.3.5 SNAPSHOT and includes demotion
of breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warning checks, this upgrade is backwards compatible and must not be
protected with new --incompatible_use_error_prone_2.3.5_version option.

Additional library is needed: threeten-extra-1.5.0.

Also bump guava version to 27.1-jre and add transitive dependency
failureaccess-1.0.1.
@davido
Copy link
Contributor Author

davido commented May 27, 2020

Upcoming EP version 2.4.0 is added the compatibility to JDK 14: google/error-prone#1639.

@davido davido changed the title Update error prone version to 2.3.4 Update error prone version to 2.4.0 May 27, 2020
davido added a commit to davido/bazel that referenced this issue May 27, 2020
@davido
Bump error prone version to 2.3.5-SNAPSHOT
2f2f25b 
Fixes: bazelbuild#11272.

This change updates error prone to 2.3.5 SNAPSHOT and includes demotion
of breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warning checks, this upgrade is backwards compatible and must not be
protected with new --incompatible_use_error_prone_2.3.5_version option.

Additional library is needed: threeten-extra-1.5.0.

Also bump guava version to 27.1-jre and add transitive dependency
failureaccess-1.0.1.
davido added a commit to davido/bazel that referenced this issue May 27, 2020
@davido
Bump error prone version to 2.3.5-SNAPSHOT
a20a9e6 
Fixes: bazelbuild#11272.

This change updates error prone to 2.3.5 SNAPSHOT and includes demotion
of breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warning checks, this upgrade is backwards compatible and must not be
protected with new --incompatible_use_error_prone_2.3.5_version option.

Additional library is needed: threeten-extra-1.5.0.
davido added a commit to davido/bazel that referenced this issue May 27, 2020
@davido
Update error prone version to 2.3.4
90b1734 
Fixes bazelbuild#11272 (first attempt that was reverted: bazelbuild#9286).
davido added a commit to davido/bazel that referenced this issue May 27, 2020
@davido
Bump error prone version to 2.3.5-SNAPSHOT
870a19b 
Fixes: bazelbuild#11272.

This change updates error prone to 2.3.5 SNAPSHOT and includes demotion
of breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warning checks, this upgrade is backwards compatible and must not be
protected with new --incompatible_use_error_prone_2.3.5_version option.

Additional library is needed: threeten-extra-1.5.0.
davido added a commit to davido/bazel that referenced this issue Jun 2, 2020
@davido
Update error prone version to 2.3.4
b410b12 
Fixes bazelbuild#11272 (first attempt that was reverted: bazelbuild#9286).
davido added a commit to davido/bazel that referenced this issue Jun 2, 2020
@davido
Bump error prone version to 2.3.5-SNAPSHOT
70adbd8 
Fixes: bazelbuild#11272.

This change updates error prone to 2.3.5 SNAPSHOT and includes demotion
of breaking changes to warning severity: ExtendsAutoValue and
RefersToDaggerCodegen. Given that Bazel EP integration does not activate
warning checks, this upgrade is backwards compatible and must not be
protected with new --incompatible_use_error_prone_2.3.5_version option.

Additional library is needed: threeten-extra-1.5.0.
@davido
Copy link
Contributor Author

davido commented Jul 14, 2020

3.4.1 was released with EP 2.4.0 included.

@davido davido closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update error prone version to 2.3.4 davido/bazel
3 participants
@davido @jin @meisterT