cc_* rules does not expand location make variables

[erenon]

Description of the problem / feature request:

The documentation says:

defines: List of defines to add to the compile line. Subject to "Make" variable substitution and Bourne shell tokenization.

It seems substitution of $(location label), $(execpath label), $(rootpath label) and their plural form does not work.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

cc_library(
    name = "makevar",
    srcs = ["foo.h"],
    data = ["foo.h"],
    defines = ['FOO="$(location foo.h)"'],
)

$ bazel aquery makevar:makevar
... in defines attribute of cc_library rule //makevar:makevar: $(location) not defined

What operating system are you running Bazel on?

Linux.

What's the output of bazel info release?

release 3.7.0

Have you found anything relevant by searching the web?

CcCommon.java:

for (String define : ruleContext.getExpander().list(attr)) {

No labelMap is passed to the expander, and it isn't enriched using withExecLocations either. I suspect the expander simply doesn't know about the labels it is supposed to resolve.