Expand make variables in defines of cc_* rules #12483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oquenchil
reviewed
Jan 14, 2021
| String.format( | ||
| "FOO=%s/foo/libfoo.a", | ||
| getTargetConfiguration() | ||
| .getBinFragment(RepositoryName.MAIN))); |
There was a problem hiding this comment.
BuildConfiguration.getBinFragment(RepositoryName) is deprecated:
Use RuleContext#getBinFragment instead whenever possible.
Please fix.
To match the documented behavior: "List of defines to add to the compile line. Subject to "Make" variable substitution and Bourne shell tokenization." https://docs.bazel.build/versions/master/be/c-cpp.html#cc_binary.defines
erenon
force-pushed
the
expand_in_defines
branch
from
c3d25d3
to
cfb6989
Compare
|
Gentle reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the documented behavior:
"List of defines to add to the compile line. Subject to "Make" variable
substitution and Bourne shell tokenization."
https://docs.bazel.build/versions/master/be/c-cpp.html#cc_binary.defines
Fixes #12482