Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel Memory Tracker is broken #13726

Closed
konste opened this issue Jul 21, 2021 · 2 comments
Closed

Bazel Memory Tracker is broken #13726

konste opened this issue Jul 21, 2021 · 2 comments
Assignees

Comments

@konste
Copy link

konste commented Jul 21, 2021

Description of the problem / feature request:

Per docummentation Bazel allows to instrument memory allocations. This feature seems to be broken.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Here is my repro repository. It only contains empty WORKSPACE file, .bazerc file with the two flags necessary to enable memory tracking and allocation_instrumenter.jar copied from the Bazel source tree. Command to run is bazel info. Seems any command would do. After running the command check the Java log in the output folder. I observe the log to grow by 4 Mb and get full of 210721 14:12:43.187:WT 1 [com.google.monitoring.runtime.instrumentation.AllocationInstrumenter.instrument] Failed to instrument class. java.lang.IllegalArgumentException

What operating system are you running Bazel on?

Windows, Mac, Linux

What's the output of bazel info release?

4.1.0, 4.2.0rc1

@katre
Copy link
Member

katre commented Jul 21, 2021

@meisterT: Can you triage this and let me know if it's a release blocker for 4.2.0?

@meisterT
Copy link
Member

This is apparently broken for a long time, so technically not a release blocker. Updating the version of the tracker library seems to help (the old version stopped working with JDK11).

meisterT added a commit to meisterT/bazel that referenced this issue Jul 22, 2021
bazel-io pushed a commit that referenced this issue Jul 23, 2021
Part of #13726.

Partial commit for third_party/*, see #13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
meisterT added a commit to meisterT/bazel that referenced this issue Jul 23, 2021
bazel-io pushed a commit that referenced this issue Jul 23, 2021
It was updated in affc27f

Part of #13726.

Closes #13734.

PiperOrigin-RevId: 386415693
meisterT added a commit to meisterT/bazel that referenced this issue Jul 23, 2021
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
meisterT added a commit to meisterT/bazel that referenced this issue Jul 23, 2021
katre pushed a commit to meisterT/bazel that referenced this issue Jul 23, 2021
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
katre pushed a commit to meisterT/bazel that referenced this issue Jul 23, 2021
meisterT added a commit to meisterT/bazel that referenced this issue Jul 26, 2021
Part of bazelbuild#13726.

Partial commit for third_party/*, see bazelbuild#13728.

Signed-off-by: Yun Peng <pcloudy@google.com>
meisterT added a commit to meisterT/bazel that referenced this issue Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants