-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop experimental_multi_threaded_digest #14034
Comments
@meisterT -- |
There used to be a check against this boolean which I assume was defaulting to
But now it always takes the slow path. I revived the fast
|
Ouch, that's definitely a mistake. I'm OOO this week but feel free to send a PR to fix the behavior. cc @Wyverald this is a release blocker |
Cherrypicks are still open. |
…been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes bazelbuild#14034
Should be reopened as it's still blocking 5.0 (needs to be cherry-picked). |
…been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes bazelbuild#14034 Closes bazelbuild#14231. PiperOrigin-RevId: 407790990 (cherry picked from commit 77a002c)
#14242) …been removed There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true and therefore would not compute the file digest in exclusive mode unless overridden to false. When that flag was removed this code was accidentally left behind which instead causes bazel to always compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE. This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds, specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds. Fixes #14034 Closes #14231. PiperOrigin-RevId: 407790990 (cherry picked from commit 77a002c) Co-authored-by: Brandon Jacklyn <brandonjacklyn@gmail.com>
Cherrypicked. |
This options defaults to true since a while and should just be removed, likely with the whole
SsdModule
.The text was updated successfully, but these errors were encountered: