-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early-adopters distribution for Windows (with chocolatey package) #1453
Comments
We need to write instructions for this, asking people to install msys and add the dll to PATH somehow. |
Just to stitch up links for others that find this, I've started this via #1742. If you tell me which dll needs to be in PATH then I can modify the chocolatey package to make that happen. |
It is msys-2.0.dll |
@dslomov so - I should add the directory containing that DLL (on my system, |
@petemounce yes, that's correct |
Ok - I'll add that to #1742 then |
Done in ad316e7 |
Having done that,
|
@meteorcloudy could you take a look? |
I guess you haven't installed Visual Studio, right? But, cc_configure should output more helpful information, I'll fix that. |
And how did you get this bazel.exe? It seems to be an old version, you can download the latest binary from our ci ( or build by yourself |
@meteorcloudy I compiled that version of bazel via I've definitely installed Visual Studio - Pro, 2015, update 3. Perhaps I haven't installed all the necessary options? Here's a shot of my install options. |
Hmm.. Looks like the installation is correct. Can you show me the content of |
I've just recompiled from 3617a54 and then used that to run
I should have been explicit - I'm running bazel from an administrator powershell.
|
I see, |
@meteorcloudy its content is @echo off
call "C:\Program Files (x86)/E r r o r : 0 x 8 0 0 7 0 0 5 7
/VC/VCVARSALL.BAT" amd64
echo PATH=%PATH%,INCLUDE=%INCLUDE%,LIB=%LIB% I think it should contain: @echo off
call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\VCVARSALL.BAT" amd64
echo PATH=%PATH%,INCLUDE=%INCLUDE%,LIB=%LIB% |
Yes, that's exactly the content on my machine. Can you try |
Or run |
msys shell:
powershell:
|
Hmm.. This is a weird problem. However, here is what I found. If it's the problem, I can fix it by checking |
I am on Win10 Anniversary edition, and bash-on-windows is installed. I also have gow installed (for things like I do not have the TL;DR - changing the the order of directories in my windows PATH so that msys is before c:\windows\system32 fixed the issue for me in powershell. I'm not sure there's a chocolatey built-in for "prepend directory to path", but I'll try to do that in the installer too. Might be separate PR. msys:
powershell (with gow installed):
powershell (with gow moved to last in my PATH):
powershell (with /usr/bin before c:\windows\system32 in PATH):
|
I also sent a change here: https://bazel-review.googlesource.com/#/c/6072/1 Thank you so much for your help! :) |
@meteorcloudy my pleasure! In #1608 it's called out that bazel does not currently support bash-on-windows, so perhaps your change should warn the user (or just silently skip) that if that bash is found ahead of msys', it won't be used yet, or the PATH should be modified so b-o-w's isn't first? |
That is a great suggestion! I think we should warm the user to either set |
In case cc_configure finds the wrong bash binary if user is running Windows 10 with bash on Windows. This should help #1453 -- Change-Id: Iffd365e3e2dd2389882390dffdf6f3a88719530e Reviewed-on: https://bazel-review.googlesource.com/#/c/6072 MOS_MIGRATED_REVID=133270634
I agree to both. I think the b-o-w binary will always be there, subject to the usual caveat of MS might change their mind at any point ;-) (I'd be surprised if it moves if it is there now, even though it's not yet rtm) |
Great! I will send the change. :) |
@meteorcloudy This is in 0.4 milestone, but the commit that will fix it is in #1742, which is not. Should the PR be added to 0.4 as well? |
We haven't cut the 0.4 yet so you are fine |
The package is in the moderation queue at https://chocolatey.org/packages/bazel/0.3.2 . The queue is quite long, currently. I'll ping here once it is approved. |
The package has been approved: https://chocolatey.org/packages/bazel/ Install via Ping @dslomov. |
w00t, awesome! Thank you @petemounce , this is great work! |
Closing because the package is available. |
A binary package that early adopters can use to quickly install Bazel on Windows
The text was updated successfully, but these errors were encountered: