Reenable tests for gRPC UDS proxy #16185
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
type: feature request
Comments
tjgq
added a commit
to tjgq/bazel
that referenced
this issue
Aug 29, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes bazelbuild#16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed bazelbuild#16185 to reenable them.
This was referenced Aug 29, 2022
tjgq
added a commit
to tjgq/bazel
that referenced
this issue
Aug 29, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes bazelbuild#16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed bazelbuild#16185 to reenable them.
copybara-service bot
pushed a commit
that referenced
this issue
Aug 29, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes #16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed #16185 to reenable them. Closes #16184. PiperOrigin-RevId: 470724658 Change-Id: Ibd7203546f00fe2335c14e7a5fa6d5bf64868bac
tjgq
added a commit
to tjgq/bazel
that referenced
this issue
Aug 29, 2022
These tests were disabled due to flakiness in 8e3c0df. As a consequence, we introduced an undetected regression in 5.3 (bazelbuild#16171). I've rerun the tests multiple times, both locally and remotely, and I've seen no evidence of flakiness. Therefore, I'm declaring that this issue has mysteriously fixed itself. Notes: * Use `python3` instead of `python` to run the UDS proxy, as the latter is no longer available in some of the environments where the tests run. * The correct URI syntax for a Unix domain socket URI is unix:///path/to/socket rather than unix:/path/to/socket, as the URI technically has no host component. The latter form still works due to lenient parsing in the gRPC gRPC library, but this may change in the future, so the tests should exercise the correct form. Fixes bazelbuild#16185.
ShreeM01
added a commit
that referenced
this issue
Aug 31, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes #16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed #16185 to reenable them. Closes #16184. PiperOrigin-RevId: 470724658 Change-Id: Ibd7203546f00fe2335c14e7a5fa6d5bf64868bac Co-authored-by: Tiago Quelhas <tjgq@google.com>
aiuto
pushed a commit
to aiuto/bazel
that referenced
this issue
Oct 12, 2022
URIs such as `unix://...` (Unix domain socket) may legitimately be missing a host component. We should gracefully handle them when looking for a credential helper (no such helper can exist for them since the lookup is host-based, but this could change in the future). Fixes bazelbuild#16171 which is a regression in 5.3. We had some tests for this in remote_execution_test.sh, but they were disabled due to flakiness in 8e3c0df. I've filed bazelbuild#16185 to reenable them. Closes bazelbuild#16184. PiperOrigin-RevId: 470724658 Change-Id: Ibd7203546f00fe2335c14e7a5fa6d5bf64868bac
coeuvre
added
type: feature request
P2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/bazel/remote/remote_execution_test.sh;l=161;drc=b303cd128d9f1d913749927f4a1cd942b10b1ae2
https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/bazel/remote/remote_execution_test.sh;l=200;drc=b303cd128d9f1d913749927f4a1cd942b10b1ae2
They were disabled due to flakiness in 8e3c0df. As a consequence, we introduced an undetected regression in 5.3 (#16171).
The text was updated successfully, but these errors were encountered: