Uninformative error message with invalid select key

[Wyverald]

Description of the bug:

The error message Bazel displays when a target uses an invalid select key is very uninformative. In particular, it doesn't tell you where the offending usage occurs.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

touch WORKSPACE
echo 'java_library(name="a", deps=["//b"])' > BUILD
mkdir b
echo 'java_library(name="b", deps=select({"//c": []}))' > b/BUILD

When you run bazel build :a, you get the following error message (and nothing else):

ERROR: Analysis of target '//:a' failed; build aborted: no such package 'c': BUILD file not found in any of the following directories. Add a BUILD file to a directory to mark it as a package.
 - /Users/wyv/test/another-test/c

It doesn't tell you that //c is being referred to from the file b/BUILD. If :a has lots of deps, it's nigh impossible to figure out what's wrong.

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

release 6.1.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

[Wyverald]

cc @katre

[Wyverald]

For the record, to figure out what was wrong initially, I had to build my own Bazel and insert a line in PackageValue#key to crash immediately when the requested package identifier is //c o,o

[gregestren]

We have a long history of analysis errors not always propagating cleanly. I can't tell offhand if this is specifically about select() or the broader analysis error issue.

Either way, good point. Agreed on the bad messaging.

[gregestren]

Probed a little bit. I wonder if we need to propagate the lookup error from

bazel/src/main/java/com/google/devtools/build/lib/skyframe/PrerequisiteProducer.java

Lines 529 to 532 in 0e6cc07

	SkyframeLookupResult packageAndMaybeConfigurationValues =
	env.getValuesAndExceptions(packageAndMaybeConfiguration);
	if (env.valuesMissing()) {
	return null;

?