Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --distinct_host_configuration #17731

Closed
katre opened this issue Mar 10, 2023 · 2 comments
Closed

Remove --distinct_host_configuration #17731

katre opened this issue Mar 10, 2023 · 2 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@katre
Copy link
Member

katre commented Mar 10, 2023

The flag --distinct_host_configuration is a no-op since Bazel 6.0.0 (specifically, since 78d0fc9).

The flag should be entirely removed, which means also removing all uses.
@katre katre self-assigned this Mar 10, 2023
@katre katre mentioned this issue Mar 10, 2023
Merged
@fmeum
Copy link
Collaborator

fmeum commented Mar 10, 2023

@katre Instead of removing the flag without replacement, would there be an option to replace it with a --distinct_exec_configuration flag?

@katre
Copy link
Member Author

katre commented Mar 10, 2023

The flag is already a no-op: this is just to track deleting it. If the feature is actually useful (and I am not convinced that it is, it involved lying to Bazel about what you were building), a new feature request can be filed and discussed.

@ShreeM01 ShreeM01 added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Mar 10, 2023
@cushon cushon mentioned this issue Mar 11, 2023
Closed
@copybara-service copybara-service bot mentioned this issue Mar 14, 2023
Closed
copybara-service bot pushed a commit to google/tsl that referenced this issue Mar 14, 2023
@tensorflower-gardener @copybara-github
PR #59955: Remove references to the Bazel flag `--distinct_host_confi…
9c53105 
…guration`.

Imported from GitHub PR tensorflow/tensorflow#59955

Part of bazelbuild/bazel#17731.
Copybara import of the project:

--
35215b3aefdfe95eedd2b5ef034d8a1f09efdeae by John Cater <jcater@google.com>:

Remove references to the Bazel flag `--distinct_host_configuration`.

Part of bazelbuild/bazel#17731.

Merging this change closes #59955

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#59955 from katre:remove-dhc 35215b3aefdfe95eedd2b5ef034d8a1f09efdeae
PiperOrigin-RevId: 516602815
@copybara-service copybara-service bot mentioned this issue Mar 14, 2023
Closed
copybara-service bot pushed a commit to google/tsl that referenced this issue Mar 14, 2023
@tensorflower-gardener @copybara-github
PR #59955: Remove references to the Bazel flag `--distinct_host_confi…
4859274 
…guration`.

Imported from GitHub PR tensorflow/tensorflow#59955

Part of bazelbuild/bazel#17731.
Copybara import of the project:

--
35215b3aefdfe95eedd2b5ef034d8a1f09efdeae by John Cater <jcater@google.com>:

Remove references to the Bazel flag `--distinct_host_configuration`.

Part of bazelbuild/bazel#17731.

Merging this change closes #59955

FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#59955 from katre:remove-dhc 35215b3aefdfe95eedd2b5ef034d8a1f09efdeae
PiperOrigin-RevId: 516602815
copybara-service bot pushed a commit to google/tsl that referenced this issue Mar 14, 2023
@katre @copybara-github
PR #59955: Remove references to the Bazel flag `--distinct_host_confi…
2993fac 
…guration`.

Imported from GitHub PR tensorflow/tensorflow#59955

Part of bazelbuild/bazel#17731.
Copybara import of the project:

--
35215b3aefdfe95eedd2b5ef034d8a1f09efdeae by John Cater <jcater@google.com>:

Remove references to the Bazel flag `--distinct_host_configuration`.

Part of bazelbuild/bazel#17731.

Merging this change closes #59955

PiperOrigin-RevId: 516637279
copybara-service bot pushed a commit to openxla/xla that referenced this issue Mar 14, 2023
@katre @copybara-github
PR #59955: Remove references to the Bazel flag `--distinct_host_confi…
cd282e8 
…guration`.

Imported from GitHub PR tensorflow/tensorflow#59955

Part of bazelbuild/bazel#17731.
Copybara import of the project:

--
35215b3aefdfe95eedd2b5ef034d8a1f09efdeae by John Cater <jcater@google.com>:

Remove references to the Bazel flag `--distinct_host_configuration`.

Part of bazelbuild/bazel#17731.

Merging this change closes #59955

PiperOrigin-RevId: 516637279
@gregestren gregestren added P1 I'll work on this now. (Assignee required) type: feature request labels Mar 20, 2023
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
@katre @fweikert
Delete the obsolete flag --distinct_host_configuration.
096b29c 
Fixes bazelbuild#17731.

RELNOTES: The flag `--distinct_host_configuration` is removed. It has been a no-op since Bazel 6.0.0.
PiperOrigin-RevId: 518366987
Change-Id: I6fff03380586cc771151ba4252eba7afba12323e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@katre @fmeum @gregestren @ShreeM01