--remote_download_toplevel --nozip_undeclared_test_outputs does not download any undeclared test outputs for passing tests #17884
Assignees
Labels
P2
We'll consider working on this in future. (Assignee optional)
team-Remote-Exec
Issues and PRs for the Execution (Remote) team
type: bug
Comments
sgowroji
added
the
team-Remote-Exec
|
Note to future self: the minimal repro for #17911 is also applicable to this issue. |
joeleba
added
P2
19 tasks
copybara-service bot
pushed a commit
that referenced
this issue
May 25, 2023
The undeclared outputs can be produced in zipped or unzipped form, depending on the value of --zip_undeclared_test_outputs; test-setup.sh is responsible for the zipping. To simplify the code, the TestRunnerAction is declared as unconditionally producing an output directory, which will either contain a single zip file, a bunch of unzipped files, or be empty if no undeclared outputs were produced. This change is required to make it possible to download the undeclared test outputs in unzipped form when building without the bytes. Related to #17884. PiperOrigin-RevId: 535188928 Change-Id: I94e72fe8840fa2274b66a2c8463cf90b4533c3a6
fweikert
pushed a commit
to fweikert/bazel
that referenced
this issue
May 25, 2023
The undeclared outputs can be produced in zipped or unzipped form, depending on the value of --zip_undeclared_test_outputs; test-setup.sh is responsible for the zipping. To simplify the code, the TestRunnerAction is declared as unconditionally producing an output directory, which will either contain a single zip file, a bunch of unzipped files, or be empty if no undeclared outputs were produced. This change is required to make it possible to download the undeclared test outputs in unzipped form when building without the bytes. Related to bazelbuild#17884. PiperOrigin-RevId: 535188928 Change-Id: I94e72fe8840fa2274b66a2c8463cf90b4533c3a6
|
@tjgq My usual question 😅 is this cherry-pickable? |
|
I don't think it's going to be possible, sorry :( there are way too many other changes that this one depends on. |
|
That is unfortunate, as it was working in 5.x, but broke in 6.x, and will only work again in 7.0 |
|
I will try to work out a dedicated fix for 6.3. |
|
@bazel-io fork 6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug:
Prior to upgrading to bazel 6.0.0, on a setup with remote execution, with
bazel test --remote_download_toplevel --nozip_undeclared_test_outputsI'd seetest.outputspopulated with files.On bazel 6.0.0,
test.outputsis always empty on passing tests.What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
With remote execution, run
bazel test --remote_download_toplevel --nozip_undeclared_test_outputs. Observe that test.outputs is empty on passing tests.Which operating system are you running Bazel on?
Linux
What is the output of
bazel info release?release 6.0.0
If
bazel info releasereturnsdevelopment versionor(@non-git), tell us how you built Bazel.No response
What's the output of
git remote get-url origin; git rev-parse master; git rev-parse HEAD?No response
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
If I remove
--nozip_undeclared_test_outputs, I seetest.outputs/outputs.zipon passing tests tooIf I remove
--remote_download_toplevel, I see the desired files intest.outputs/*on passing tests tooAdding
--experimental_remote_download_regex=".*"didn't help.The text was updated successfully, but these errors were encountered: