Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Automatic use_repo fixups for module extensions" #17908

Closed
fmeum opened this issue Mar 29, 2023 · 0 comments
Closed

Implement "Automatic use_repo fixups for module extensions" #17908

fmeum opened this issue Mar 29, 2023 · 0 comments
Assignees
@fmeum
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process

Comments

@fmeum
Copy link
Collaborator

fmeum commented Mar 29, 2023

Proposal: https://docs.google.com/document/d/1dj8SN5L6nwhNOufNqjBhYkk5f-BJI_FPYWKxlB3GAmA/edit
@fmeum fmeum added P1 I'll work on this now. (Assignee required) area-Bzlmod Bzlmod-specific PRs, issues, and feature requests labels Mar 29, 2023
@fmeum fmeum self-assigned this Mar 29, 2023
@sgowroji sgowroji added type: process team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Mar 29, 2023
fmeum added a commit to fmeum/bazel that referenced this issue Mar 29, 2023
@fmeum
Add module_ctx.is_dev_dependency
ad59144 
Allows module extensions to determine whether a given tag represents a
dev dependency.

Fixes bazelbuild#17101
Work towards bazelbuild#17908
@fmeum fmeum mentioned this issue Mar 29, 2023
Closed
fmeum added a commit to fmeum/bazel that referenced this issue Mar 29, 2023
@fmeum
Add module_ctx.is_dev_dependency
a18f6cc 
Allows module extensions to determine whether a given tag represents a
dev dependency.

Fixes bazelbuild#17101
Work towards bazelbuild#17908
This was referenced Mar 30, 2023
Merged
Merged
copybara-service bot pushed a commit that referenced this issue Mar 30, 2023
@fmeum @copybara-github
Add module_ctx.is_dev_dependency
1a719ce 
Allows module extensions to determine whether a given tag represents a dev dependency.

Fixes #17101
Work towards #17908

Closes #17909.

PiperOrigin-RevId: 520645663
Change-Id: I3e3136a09d01d25fc706bcd0dfd7e53b6e7d5285
ShreeM01 pushed a commit to ShreeM01/bazel that referenced this issue Mar 30, 2023
@fmeum @ShreeM01
Add module_ctx.is_dev_dependency
843ca59 
Allows module extensions to determine whether a given tag represents a dev dependency.

Fixes bazelbuild#17101
Work towards bazelbuild#17908

Closes bazelbuild#17909.

PiperOrigin-RevId: 520645663
Change-Id: I3e3136a09d01d25fc706bcd0dfd7e53b6e7d5285
@ShreeM01 ShreeM01 mentioned this issue Mar 30, 2023
Merged
Wyverald pushed a commit that referenced this issue Mar 31, 2023
@ShreeM01 @fmeum @keertk
[6.2.0]Add module_ctx.is_dev_dependency (#17934)
3ea18cc 
* Add `module_ctx.is_dev_dependency`

Allows module extensions to determine whether a given tag represents a dev dependency.

Fixes #17101
Work towards #17908

Closes #17909.

PiperOrigin-RevId: 520645663
Change-Id: I3e3136a09d01d25fc706bcd0dfd7e53b6e7d5285

* Revert section that was accidentally cherry-picked

---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: keertk <keerthanakumar@google.com>
This was referenced Apr 4, 2023
Closed
Closed
Closed
@fmeum fmeum mentioned this issue Apr 18, 2023
Merged
Wyverald pushed a commit that referenced this issue Apr 21, 2023
@fmeum @Wyverald
Add module_ctx.extension_metadata
673c8c3 
Fixes #17908

Closes #17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb
@Wyverald Wyverald mentioned this issue Apr 21, 2023
Merged
keertk pushed a commit that referenced this issue Apr 21, 2023
@Wyverald @fmeum
Add module_ctx.extension_metadata (#18174)
6c61110 
Fixes #17908

Closes #17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
@fmeum @fweikert
Add module_ctx.is_dev_dependency
f3ffb0a 
Allows module extensions to determine whether a given tag represents a dev dependency.

Fixes bazelbuild#17101
Work towards bazelbuild#17908

Closes bazelbuild#17909.

PiperOrigin-RevId: 520645663
Change-Id: I3e3136a09d01d25fc706bcd0dfd7e53b6e7d5285
fweikert pushed a commit to fweikert/bazel that referenced this issue May 25, 2023
@fmeum @fweikert
Add module_ctx.extension_metadata
89931db 
Fixes bazelbuild#17908

Closes bazelbuild#17970.

PiperOrigin-RevId: 525134299
Change-Id: I9088e3f4561c0c27135cfdd1e5be8390ea8da7eb
@ar3s3ru ar3s3ru mentioned this issue Dec 7, 2023
Open
@matts1 matts1 mentioned this issue Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmeum fmeum

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add module_ctx.extension_metadata fmeum/bazel
2 participants
@fmeum @sgowroji