Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_disallow_struct_provider_syntax #19467

Open
comius opened this issue Sep 8, 2023 · 1 comment
Open

incompatible_disallow_struct_provider_syntax #19467

comius opened this issue Sep 8, 2023 · 1 comment
Assignees
Labels
incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green

Comments

@comius
Copy link
Contributor

comius commented Sep 8, 2023

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers

@comius comius added incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green labels Sep 8, 2023
@comius comius self-assigned this Sep 8, 2023
@acozzette
Copy link
Contributor

I tried enabling this flag but hit an error here in some Starlark code inside Bazel itself:

copybara-service bot pushed a commit to protocolbuffers/protobuf that referenced this issue Jan 10, 2024
This change makes our Bazel build compatible with all the migration-ready
`--incompatible` flags listed
[here](https://github.com/bazelbuild/bazel/releases/tag/7.0.0) for Bazel 7.0,
with a couple exceptions listed below. This was mostly just a matter of
updating some of our dependencies to more recent versions.

The two flags we cannot support yet are these:
 - `--incompatible_disallow_struct_provider_syntax`: Bazel itself appears not
   to support this one yet, see
   [here](bazelbuild/bazel#19467).
 - `--incompatible_stop_exporting_language_modules`: waiting on support in
   `rules_jvm_external`, see
   [here](bazel-contrib/rules_jvm_external#1027).

I also deleted the broken `//:protobuf_nowkt` alias target, which was an
oversight on my part from a previous change.

PiperOrigin-RevId: 597076542
copybara-service bot pushed a commit to protocolbuffers/protobuf that referenced this issue Jan 10, 2024
This change makes our Bazel build compatible with all the migration-ready
`--incompatible` flags listed
[here](https://github.com/bazelbuild/bazel/releases/tag/7.0.0) for Bazel 7.0,
with a couple exceptions listed below. This was mostly just a matter of
updating some of our dependencies to more recent versions.

The two flags we cannot support yet are these:
 - `--incompatible_disallow_struct_provider_syntax`: Bazel itself appears not
   to support this one yet, see
   [here](bazelbuild/bazel#19467).
 - `--incompatible_stop_exporting_language_modules`: waiting on support in
   `rules_jvm_external`, see
   [here](bazel-contrib/rules_jvm_external#1027).

I also deleted the broken `//:protobuf_nowkt` alias target, which was an
oversight on my part from a previous change.

PiperOrigin-RevId: 597076542
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Apr 19, 2024
This is a prerequisite to finally turn down legacy struct providers. The last such instance is used in rules_kotlin. And it's used to serve as integration with IntelliJ.

After this change, PR bazelbuild/rules_kotlin#1157 may be merged, keeping rules_kotlin working with IntelliJ.

Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers
Issue: bazelbuild/bazel#19467
PiperOrigin-RevId: 626344394
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Apr 19, 2024
This is a prerequisite to finally turn down legacy struct providers. The last such instance is used in rules_kotlin. And it's used to serve as integration with IntelliJ.

After this change, PR bazelbuild/rules_kotlin#1157 may be merged, keeping rules_kotlin working with IntelliJ.

Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers
Issue: bazelbuild/bazel#19467
PiperOrigin-RevId: 626344394
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Apr 23, 2024
This is a prerequisite to finally turn down legacy struct providers. The last such instance is used in rules_kotlin. And it's used to serve as integration with IntelliJ.

After this change, PR bazelbuild/rules_kotlin#1157 may be merged, keeping rules_kotlin working with IntelliJ.

Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers
Issue: bazelbuild/bazel#19467
PiperOrigin-RevId: 626344394
copybara-service bot pushed a commit to bazelbuild/intellij that referenced this issue Apr 23, 2024
This is a prerequisite to finally turn down legacy struct providers. The last such instance is used in rules_kotlin. And it's used to serve as integration with IntelliJ.

After this change, PR bazelbuild/rules_kotlin#1157 may be merged, keeping rules_kotlin working with IntelliJ.

Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers
Issue: bazelbuild/bazel#19467
PiperOrigin-RevId: 627353414
mai93 pushed a commit to bazelbuild/intellij that referenced this issue May 6, 2024
This is a prerequisite to finally turn down legacy struct providers. The last such instance is used in rules_kotlin. And it's used to serve as integration with IntelliJ.

After this change, PR bazelbuild/rules_kotlin#1157 may be merged, keeping rules_kotlin working with IntelliJ.

Legacy struct providers have been deprecated by Bazel. Replacing them with modern providers, will make it possible to simplify and remove legacy handling from Bazel.

More info on: https://bazel.build/extending/rules#migrating_from_legacy_providers
Issue: bazelbuild/bazel#19467
(cherry picked from commit 702227e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible-change Incompatible/breaking change migration-ready Incompatible flag is ready for migration with Bazel rolling releases or Bazel@last_green
Projects
None yet
Development

No branches or pull requests

2 participants