Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Bzlmod in all test cases for Bazel #19824

Closed
4 tasks done
meteorcloudy opened this issue Oct 16, 2023 · 0 comments
Closed
4 tasks done

Enable Bzlmod in all test cases for Bazel #19824

meteorcloudy opened this issue Oct 16, 2023 · 0 comments
Assignees
@Wyverald @meteorcloudy
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Oct 16, 2023 •
edited
Loading

After #19817, there are still some Bazel tests with Bzlmod disabled.

Major base test cases to be migrated:

Disabled due to actual Bazel bugs:

To find out whereelse Bzlmod is disabled:
@meteorcloudy meteorcloudy added P2 We'll consider working on this in future. (Assignee optional) area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug labels Oct 16, 2023
copybara-service bot pushed a commit that referenced this issue Oct 16, 2023
@meteorcloudy @copybara-github
Flip --enable_bzlmod to true
30d033c 
Bazel tests status:

- Bzlmod disabled:

  - AnalysisTestCase: to be migrated
  - ConfigurationTestCase: to be migrated
  - ConfigCommandTest: to be migrated, probably blocked by a bug

- Bzlmod enabled:

  - BuildViewTestCase: migrated at d51144c
  - Java integration tests migrated at 8d04711
  - Shell integration tests migrated at 175a18d (Bzlmod disabled in some tests)
  - Python integration tests migrated at 50c8375 (Bzlmod disabled in some tests)
  - BuildIntegrationTestCase: migrated in this change
  - Other Java unit tests migrated in this change

Issues identified:

- cc_shared_library doesn't work well with Bzlmod: #19822
- `bazel config` doesn't work well with Bzlmod: #19823

Fixes #18958

Tracking migration of remaining test cases in #19824

RELNOTES[INC]: Bzlmod is enabled by default, please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. Find more details at #18958

PiperOrigin-RevId: 573827480
Change-Id: I097b4bd7caafc996b034284ee688b8f3d2bca1f7
@meteorcloudy meteorcloudy mentioned this issue Nov 27, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Aug 19, 2024
@meteorcloudy @copybara-github
Enable Bzlmod in AnalysisTestCase.java
f848b06 
Working towards: #19824

Related: #23023

Part of: #23253

PiperOrigin-RevId: 664876902
Change-Id: I8386b13fd12f5d4fb0599c0142df668b0c4a7f74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wyverald Wyverald

@meteorcloudy meteorcloudy

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
Bzlmod
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wyverald @meteorcloudy