Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Starlark Transition Composition #22248

Open
katre opened this issue May 6, 2024 · 0 comments
Open

Implement Starlark Transition Composition #22248

katre opened this issue May 6, 2024 · 0 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@katre
Copy link
Member

katre commented May 6, 2024

Tracking issue for implementation of https://github.com/bazelbuild/proposals/blob/main/designs/2024-04-16-transition-composition.md.
@katre katre added type: feature request P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels May 6, 2024
@katre katre self-assigned this May 6, 2024
copybara-service bot pushed a commit that referenced this issue May 7, 2024
@katre @copybara-github
Test using an actual native transition.
3a876d0 
Part of #22248.

PiperOrigin-RevId: 631416237
Change-Id: I91d40ad30673ee352624a1580a23de3855a28bd0
copybara-service bot pushed a commit that referenced this issue May 7, 2024
@katre @copybara-github
Add a test to ensure the Starlark-exposed Android transitions are usa…
92682de 
…ble.

(This was accidentally broken with no tests by a pending change).

Part of #22248.

PiperOrigin-RevId: 631447201
Change-Id: Ie099705b35aff672efe0ee71b26d28aca2836a4f
copybara-service bot pushed a commit that referenced this issue May 9, 2024
@katre @copybara-github
Add tests for using the cfg parameter to rule().
21eedc8 
Also split StarlarkRuleClassTests into its own target.

Part of #22248.

PiperOrigin-RevId: 632182116
Change-Id: Ia6dcf68f45d1fd8b48026ee94c827bdc9ad992ce
copybara-service bot pushed a commit that referenced this issue May 9, 2024
@katre @copybara-github
Add visitor pattern for transition factories.
c7c33b1 
Part of #22248.

PiperOrigin-RevId: 632193752
Change-Id: Ic41afbc4ec508ad08615a8861278d5593bb73849
copybara-service bot pushed a commit that referenced this issue May 10, 2024
@katre @copybara-github
Require TransitionFactory subclasses to implement transitionType.
81ca4aa 
This guarantees that it is accurate, the default of `ANY` was too broad.

Part of #22248.

PiperOrigin-RevId: 632513554
Change-Id: I90b66b45b640ba84b658f23cb56a9016dd853310
copybara-service bot pushed a commit that referenced this issue May 10, 2024
@katre @copybara-github
Refactor code that handles incoming Starlark rule configuration trans…
d896540 
…itions.

Part of #22248.

PiperOrigin-RevId: 632514548
Change-Id: I3a0864e3fd11d318e33b10be9367dd51c383d599
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Test using an actual native transition.
a15f4cc 
Part of bazelbuild#22248.

PiperOrigin-RevId: 631416237
Change-Id: I91d40ad30673ee352624a1580a23de3855a28bd0
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Add a test to ensure the Starlark-exposed Android transitions are usa…
d8bf7c9 
…ble.

(This was accidentally broken with no tests by a pending change).

Part of bazelbuild#22248.

PiperOrigin-RevId: 631447201
Change-Id: Ie099705b35aff672efe0ee71b26d28aca2836a4f
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Add tests for using the cfg parameter to rule().
cd53b9f 
Also split StarlarkRuleClassTests into its own target.

Part of bazelbuild#22248.

PiperOrigin-RevId: 632182116
Change-Id: Ia6dcf68f45d1fd8b48026ee94c827bdc9ad992ce
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Add visitor pattern for transition factories.
d690a69 
Part of bazelbuild#22248.

PiperOrigin-RevId: 632193752
Change-Id: Ic41afbc4ec508ad08615a8861278d5593bb73849
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Require TransitionFactory subclasses to implement transitionType.
0bdccf7 
This guarantees that it is accurate, the default of `ANY` was too broad.

Part of bazelbuild#22248.

PiperOrigin-RevId: 632513554
Change-Id: I90b66b45b640ba84b658f23cb56a9016dd853310
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@katre @Kila2
Refactor code that handles incoming Starlark rule configuration trans…
3d057b7 
…itions.

Part of bazelbuild#22248.

PiperOrigin-RevId: 632514548
Change-Id: I3a0864e3fd11d318e33b10be9367dd51c383d599
copybara-service bot pushed a commit that referenced this issue May 13, 2024
@katre @copybara-github
Native transitions (factories and direct transitions) exposed to Star…
f2276e5 
…lark should implement ConfigurationTransitionApi.

StarlarkExposedRuleTransitionFactory is clarified, and is not itself exposed to Starlark.

Part of #22248.

PiperOrigin-RevId: 633199947
Change-Id: I19032aaf6b4db1ae5c496077495a01f8b6c4d0b0
copybara-service bot pushed a commit that referenced this issue May 13, 2024
@katre @copybara-github
Move StarlarkConfigApi into starlarkbuildapi/config.
0f97a76 
Part of #22248.

PiperOrigin-RevId: 633201757
Change-Id: I4b1127358eabcd3438eaa8adde9a48d55efb6394
copybara-service bot pushed a commit that referenced this issue May 14, 2024
@katre @copybara-github
Expose the default no-op transition to Starlark users.
283b585 
This is the same transition as `cfg = "target"`.

RELNOTES: A no-op transition is now available as `config.target()`.

Part of #22248.

PiperOrigin-RevId: 633665060
Change-Id: I63f81d1378b6af7ed4fb4b81ea1df3db9de526ad
copybara-service bot pushed a commit that referenced this issue May 22, 2024
@katre @copybara-github
Remove unused NullTransition.
56739f4 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 636209749
Change-Id: I9ecdec8b376a9c95b06dea36bacbf9268d0c5195
copybara-service bot pushed a commit that referenced this issue May 22, 2024
@katre @copybara-github
Split ConfigurationTransitionApi to a new target.
739f7b8 
This helps to reduce dependency cycles.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 636260650
Change-Id: I17c0137e9d442fb02cf51e360ede876b4d92f6c4
copybara-service bot pushed a commit that referenced this issue May 23, 2024
@katre @copybara-github
Remove use of the TransitionFactories conversion utilities in tests.
c4e8848 
Part of entirely removing TransitionFactories: we should directly create and use factories everywhere. Future changes will continue with this theme.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 636641944
Change-Id: Ib345da940cb78867484411b4abda4f8d55cb2ba2
copybara-service bot pushed a commit that referenced this issue May 23, 2024
@katre @copybara-github
Mark more Starlark-exposed transitions with the correct API interface.
29afc34 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 636644277
Change-Id: I08bd0d006e5d68f195bc4bada1c782982fc70528
copybara-service bot pushed a commit that referenced this issue May 28, 2024
@katre @copybara-github
Remove support for adding non-exported transitions to Starlark attrib…
b4d3b84 
…utes.

Any native transitions must be exposed using ConfiguredTransitionApi.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 637945670
Change-Id: I712ead0e32ada463bbe024ab616ea96f50155f0d
copybara-service bot pushed a commit that referenced this issue May 28, 2024
@katre @copybara-github
Remove the TransitionFactories utility class.
fa9c648 
This does not change the TransitionFactory interface, simply removes some unused support utilities.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 637971545
Change-Id: Ifae5433ebb71a542660a70f0b4f17379037284fa
copybara-service bot pushed a commit that referenced this issue May 31, 2024
@katre @copybara-github
Use a single instance for all NoTransition and NoConfigTransition fac…
870e7c6 
…tory uses.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 639026960
Change-Id: I46e0ebbd25a8708c944bee69da9a9582543da9b1
copybara-service bot pushed a commit that referenced this issue Jun 3, 2024
@katre @copybara-github
Provide a default for RuleClass.transitionFactory.
a67dac5 
This removes a lot of useless null checks.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 639805169
Change-Id: I45b4f4b7cf71e568578956d6b7723fc999f5afc8
copybara-service bot pushed a commit that referenced this issue Jun 3, 2024
@katre @copybara-github
Simplify code used to determine rule transitions.
5f01bfa 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 639906031
Change-Id: I9ec95ba8c9a7986ebeac1f18f56578954eec5868
copybara-service bot pushed a commit that referenced this issue Jun 4, 2024
@katre @copybara-github
Simplify naming of transitions in cquery output.
69802ba 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 640136865
Change-Id: Ia4d45e20d4a2bbcff2f625e22b9ab53ec81927ba
copybara-service bot pushed a commit that referenced this issue Jun 4, 2024
@katre @copybara-github
Remove ComposingTransition, all uses should be of ComposingTransition…
490e023 
…Factory.

Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 640178803
Change-Id: Ida2f94e61679fbe4687545ab9fbb700ebe856877
copybara-service bot pushed a commit that referenced this issue Jun 7, 2024
@katre @copybara-github
Move starlark analysis tests to a dedicated package.
7a27f1b 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 641213714
Change-Id: If39b197545836fcba1428c1854fadfe90969ec63
copybara-service bot pushed a commit that referenced this issue Jun 7, 2024
@katre @copybara-github
Remove inaccurate comment about rule transition attrs.
bf83dea 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 641254883
Change-Id: I75acc0ff8939f38fc4d97c1e1e56b0d0123e17c3
copybara-service bot pushed a commit that referenced this issue Jun 7, 2024
@katre @copybara-github
Hide StarlarkDefinedConfigTransition's rule transition cache.
80b17f8 
Work towards composable starlark transitions: #22248.

PiperOrigin-RevId: 641274834
Change-Id: Icf7147925af0f0d52f35142782286f6635c48777
copybara-service bot pushed a commit that referenced this issue Jul 22, 2024
@katre @copybara-github
Define a new Starlark API to create exec transitions.
f126238 
Currently this is only usable within the builtin rules.

This is intended to reduce the complexity of the StarlarkDefinedConfigTransition, by making it easier to tell if a transition has the extra capabilities of the exec transition.

Work towards composable starlark transitions: #22248. Also part of fixing #22996.

PiperOrigin-RevId: 654886740
Change-Id: I1d5292bc2e5e8646e5563f0a2cd3afd9b2157659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre