[Bazel CI] Build Error: Name android_sdk_repository is not defined in WORKSPACE.bzlmod

[sgowroji]

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4114#0191da32-9228-418e-a605-7b8b69fb7db7

Platform: MacOS, Windows, Ubuntu

Logs:

ERROR: /Users/buildkite/builds/bk-macos-pln3-7ote/bazel-org-repo-root/bazel/WORKSPACE.bzlmod:48:1: name 'android_sdk_repository' is not defined
(06:47:28) WARNING: Option 'experimental_build_event_json_file_path_conversion' is deprecated: Use --build_event_json_file_path_conversion instead
(06:47:28) WARNING: Option 'remote_default_platform_properties' is deprecated: --remote_default_platform_properties has been deprecated in favor of --remote_default_exec_properties.
(06:47:29) WARNING: Build option --test_env has changed, discarding analysis cache (this can be expensive, see https://bazel.build/advanced/performance/iteration-speed).
(06:47:30) WARNING: Download from https://mirror.bazel.build/github.com/google/googletest/archive/refs/tags/v1.14.0.tar.gz failed: class java.io.FileNotFoundException GET returned 404 Not Found
(06:47:30) ERROR: /Users/buildkite/builds/bk-macos-pln3-7ote/bazel-org-repo-root/bazel/WORKSPACE: no such target '//external:has_androidsdk': target 'has_androidsdk' not declared in package 'external' defined by /Users/buildkite/builds/bk-macos-pln3-7ote/bazel-org-repo-root/bazel/WORKSPACE
(06:47:30) ERROR: /Users/buildkite/builds/bk-macos-pln3-7ote/bazel-org-repo-root/bazel/src/test/java/com/google/devtools/build/android/r8/BUILD:18:13: errors encountered resolving select() keys for //src/test/java/com/google/devtools/build/android/r8:tests
(06:47:30) ERROR: Analysis of target '//src/test/java/com/google/devtools/build/android/r8:AllTests' failed; build aborted: Analysis failed
(06:47:30) INFO: Elapsed time: 2.459s, Critical Path: 0.01s
(06:47:30) INFO: 1 process: 1 internal.
(06:47:30) ERROR: Build did NOT complete successfully
(06:47:30) ERROR: No test targets were found, yet testing was requested
(06:47:30) INFO: Build Event Protocol files produced successfully.
(06:47:30) FAILED:

Culprit:

Steps:

git clone https://github.com/bazelbuild/bazel
git reset 10060cd638027975480ae56b5e38dd1a0991d49c  --hard
export USE_BAZEL_VERSION=10060cd638027975480ae56b5e38dd1a0991d49c
bazel test //scripts:bash_completion_test //src/test/cpp/util:md5_test //src/test/cpp:bazel_startup_options_test //src/test/cpp:startup_options_test //src/test/java/com/google/devtools/build/android/r8:AllTests //src/test/java/com/google/devtools/build/android/ziputils:ziputils-tests //src/test/java/com/google/devtools/build/android:AndroidDataWriterTest //src/test/java/com/google/devtools/build/android:ConvertersTest //src/test/java/com/google/devtools/build/android:DensitySpecificResourceFilterTest //src/test/java/com/google/devtools/build/android:RClassGeneratorActionTest //src/test/java/com/google/devtools/build/docgen:DocumentationTests //src/test/java/com/google/devtools/build/lib/analysis/config:FeatureSetTest //src/test/java/com/google/devtools/build/lib/analysis/select:SelectTests //src/test/java/com/google/devtools/build/lib/analysis/starlark:StarlarkCustomCommandLineTest //src/test/java/com/google/devtools/build/lib/analysis:AbstractConfiguredTargetTest //src/test/java/com/google/devtools/build/lib/analysis:ConfiguredTargetTransitivePackagesTest //src/test/java/com/google/devtools/build/lib/analysis:RunfilesRepoMappingManifestTest //src/test/java/com/google/devtools/build/lib/authandtls:AuthAndTlsTests //src/test/java/com/google/devtools/build/lib/bazel/repository/cache:RepositoryCacheTests //src/test/java/com/google/devtools/build/lib/bazel/rules/java:JavaTests //src/test/java/com/google/devtools/build/lib/blackbox/junit:TimeoutTestWatcherTest //src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace:WorkspaceBlackBoxTest //src/test/java/com/google/devtools/build/lib/buildeventservice:BuildEventTransportTest //src/test/java/com/google/devtools/build/lib/buildtool:CompileOneDependencyIntegrationTest //src/test/java/com/google/devtools/build/lib/buildtool:DirectoryArtifactWarningTest //src/test/java/com/google/devtools/build/lib/buildtool:InstrumentationFilterSupportTest //src/test/java/com/google/devtools/build/lib/buildtool:MissingInputActionTest //src/test/java/com/google/devtools/build/lib/buildtool:ProgressReportingTest //src/test/java/com/google/devtools/build/lib/buildtool:SkymeldBuildIntegrationTest //src/test/java/com/google/devtools/build/lib/buildtool:TargetCompleteEventTest //src/test/java/com/google/devtools/build/lib/cmdline:LabelInternerIntegrationTest //src/test/java/com/google/devtools/build/lib/dynamic:DynamicSpawnStrategyTest //src/test/java/com/google/devtools/build/lib/exec/local:PosixLocalEnvProviderTest //src/test/java/com/google/devtools/build/lib/io:IoTests //src/test/java/com/google/devtools/build/lib/metrics:PsInfoCollectorTest //src/test/java/com/google/devtools/build/lib/packages:BazelDocumentationTests //src/test/java/com/google/devtools/build/lib/pkgcache:IncrementalLoadingTest //src/test/java/com/google/devtools/build/lib/pkgcache:TargetPatternEvaluatorTest //src/test/java/com/google/devtools/build/lib/platform:SystemThermalEventTest //src/test/java/com/google/devtools/build/lib/query2/common:QueryTaskFutureImplTest //src/test/java/com/google/devtools/build/lib/query2/cquery:FilesOutputFormatterCallbackTest //src/test/java/com/google/devtools/build/lib/query2/query/output:SyntheticAttributeHashCalculatorTest //src/test/java/com/google/devtools/build/lib/remote/http:http //src/test/java/com/google/devtools/build/lib/remote:BuildWithoutTheBytesIntegrationTest //src/test/java/com/google/devtools/build/lib/rules/android:AndroidDataConverterTest //src/test/java/com/google/devtools/build/lib/rules/cpp/proto:CcProtoLibraryTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CcBinaryThinLtoObjDirTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CcImportConfiguredTargetTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CcToolchainProviderTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CppConfigurationStarlarkTest //src/test/java/com/google/devtools/build/lib/rules/cpp:CppModulesConfiguredTargetTest //src/test/java/com/google/devtools/build/lib/rules/cpp:LibraryLinkingTest //src/test/java/com/google/devtools/build/lib/rules/cpp:NonWindowsCcBinaryThinLtoTest //src/test/java/com/google/devtools/build/lib/rules/genquery:genquery_tests //src/test/java/com/google/devtools/build/lib/rules/java:JavaConfigurationTest //src/test/java/com/google/devtools/build/lib/rules/java:JavaOptionsTest //src/test/java/com/google/devtools/build/lib/rules/objc:BazelJ2ObjcLibraryTest //src/test/java/com/google/devtools/build/lib/rules/proto:ProtoConfigurationTest //src/test/java/com/google/devtools/build/lib/rules/python:PyLibraryConfiguredTargetTest //src/test/java/com/google/devtools/build/lib/rules/python:PythonStarlarkApiTest //src/test/java/com/google/devtools/build/lib/rules/starlarkdocextract:StarlarkDocExtractTests //src/test/java/com/google/devtools/build/lib/runtime:RunCommandLineTest //src/test/java/com/google/devtools/build/lib/shell:CommandResultTest //src/test/java/com/google/devtools/build/lib/shell:InterruptibleTest //src/test/java/com/google/devtools/build/lib/shell:TerminationStatusTest //src/test/java/com/google/devtools/build/lib/skyframe/config:PlatformMappingFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization/strings:UnsafeStringCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:DictCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:IgnoredPackagePrefixesValueCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:MutableListCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:ProfileCollectorTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:SingletonCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/serialization:WorkspaceNameValueCodecTest //src/test/java/com/google/devtools/build/lib/skyframe/toolchains:SingleToolchainResolutionFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:ActionExecutionValueTest //src/test/java/com/google/devtools/build/lib/skyframe:BuiltinsInjectionTest //src/test/java/com/google/devtools/build/lib/skyframe:BzlLoadKeyCodecTest //src/test/java/com/google/devtools/build/lib/skyframe:ConfiguredTargetKeyTest //src/test/java/com/google/devtools/build/lib/skyframe:DirtinessCheckerUtilsTest //src/test/java/com/google/devtools/build/lib/skyframe:FileValueTest //src/test/java/com/google/devtools/build/lib/skyframe:GlobsFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:LocalRepositoryLookupFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:PackageLookupFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:PrepareDepsOfPatternsFunctionSmartNegationTest //src/test/java/com/google/devtools/build/lib/skyframe:RecursiveFilesystemTraversalFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:RepositoryMappingFunctionTest //src/test/java/com/google/devtools/build/lib/skyframe:SkyframeFilesystemIntegrationTest //src/test/java/com/google/devtools/build/lib/skyframe:TargetPatternPhaseKeyTest //src/test/java/com/google/devtools/build/lib/skyframe:TrackSourceDirectoriesIntegrationTest //src/test/java/com/google/devtools/build/lib/skyframe:WorkspaceFileFunctionTest //src/test/java/com/google/devtools/build/lib/starlark:StarlarkTests //src/test/java/com/google/devtools/build/lib/starlarkdocextract:LabelRendererTest //src/test/java/com/google/devtools/build/lib/testing/common:FakeOptionsTest //src/test/java/com/google/devtools/build/lib/util:FileTypeWindowsTests //src/test/java/com/google/devtools/build/lib/versioning:GnuVersionParserTest //src/test/java/com/google/devtools/build/lib/view/java:JavaCompilationArgsTest //src/test/java/com/google/devtools/build/lib/view/java:JavaPluginConfiguredTargetTest //src/test/java/com/google/devtools/build/skyframe:SkyframeTests //src/test/java/net/starlark/java/eval:EvalTests //src/test/native/windows:process_test //src/test/shell/bazel:bazel_bootstrap_distfile_test //src/tools/singlejar:combiners_test //src/tools/singlejar:options_test //src/tools/singlejar:zip_headers_test //third_party/ijar/test:zip_test //tools/python/runfiles:runfiles_test 

CC Greenteam @meteorcloudy

[meteorcloudy]

This is caused by 34c359c

@ted-xie @katre @ahumesky What's the plan for the remaining android tests in the Bazel repo? They already don't work with Bazel@HEAD after this change, can we remove them already or should we wait for rules_android to be ready?

[katre]

I'll defer to @ted-xie and @ahumesky but they can probably just be deleted.

[ahumesky]

These are tests for tools that the android rules use, we want to move this code to rules_android, so we don't want to delete this quite yet. Let me see if I can quickly get this working again. Failing that we can just disable the test.

[ahumesky]

So to get this to work again we'd need to add the Starlark android rules and set up a number of things with the SDK in the module file, and rules_android is using newer versions of rules_go, rules_python, rules_jvm_external, stardoc, and bazel_skylib, so I'd need to update those, and I don't think the churn is worth it, so I'll just disable these tests

[meteorcloudy]

I think we'll have to disable also other android tests like //src/test/shell/bazel/android/..., is that also fine?

Oh, it's already basically empty. So probably not.