Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: get rid of hardcoded tools/msys64 paths #2447

Closed
laszlocsomor opened this issue Jan 30, 2017 · 3 comments
Closed

Windows: get rid of hardcoded tools/msys64 paths #2447

laszlocsomor opened this issue Jan 30, 2017 · 3 comments
Assignees
@hlopko
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows type: feature request
Milestone
0.6

Comments

@laszlocsomor
Copy link
Contributor

"tools/msys64" is hardcoded in some locations.
Get rid of these and only use the BAZEL_SH envvar.

This is part of the larger effort known as #2107
@laszlocsomor laszlocsomor added platform: windows P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request labels Jan 30, 2017
@laszlocsomor
Copy link
Contributor Author

@mhlopko : FYI, CROSSTOOL is an example where this is hardcoded

@laszlocsomor laszlocsomor mentioned this issue Jan 30, 2017
Closed
@dslomov dslomov added this to the 0.5 milestone Feb 14, 2017
bazel-io pushed a commit that referenced this issue Mar 23, 2017
@laszlocsomor @hermione521
cc_configure: more generic msys_root discovery
832548d 
See #2725
Related to #2447

--
Change-Id: I5cc7fba43ae46bc9ef47bcaf9efaf2a0b9911bc4
Reviewed-on: https://cr.bazel.build/9468
PiperOrigin-RevId: 150881196
MOS_MIGRATED_REVID=150881196
bazel-io pushed a commit that referenced this issue Mar 23, 2017
@laszlocsomor @hermione521
Cygwin support: fix junitrunner BUILD file
1a09e7e 
See #2725
Related to #2447

--
Change-Id: I723764ee1b41caf62a7d71abcdcdfb704521f206
Reviewed-on: https://cr.bazel.build/9511
PiperOrigin-RevId: 150882100
MOS_MIGRATED_REVID=150882100
bazel-io pushed a commit that referenced this issue Mar 23, 2017
@laszlocsomor @hermione521
Bazel client, Windows: fix MSYS root computation
99847a1 
Make it more robust: it now works with Cygwin too,
e.g. BAZEL_SH=c:/cygwin64/bin/bash.exe

See #2725
Related to #2447

--
Change-Id: I911f09acd3e39c7cd0fe0750774fa0a900ffd844
Reviewed-on: https://cr.bazel.build/9510
PiperOrigin-RevId: 150885982
MOS_MIGRATED_REVID=150885982
@laszlocsomor
Copy link
Contributor Author

This bug is related to #2725

@hlopko hlopko assigned hlopko and unassigned laszlocsomor Mar 23, 2017
@dslomov dslomov modified the milestones: 0.6, 0.5 Apr 4, 2017
@dslomov
Copy link
Contributor

dslomov commented Jul 24, 2017

The remaining occurrences are either in tests or in CROSSTOOL for gcc. Closing this (we do not see many requests for supporting gcc on Windows, and when we do, we will need to redesign it from scratch)

@dslomov dslomov closed this as completed Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) platform: windows type: feature request
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@hlopko @dslomov @laszlocsomor