Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--zip_undeclared_test_outputs=false crashes Bazel if tests create outputs in nested subdirectories #24578

Closed
hvadehra opened this issue Dec 5, 2024 · 3 comments
Closed

--zip_undeclared_test_outputs=false crashes Bazel if tests create outputs in nested subdirectories #24578

hvadehra opened this issue Dec 5, 2024 · 3 comments
Assignees
@tjgq
Labels
P1 I'll work on this now. (Assignee required) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug

Comments

@hvadehra
Copy link
Member

hvadehra commented Dec 5, 2024 •
edited
Loading

Description of the bug:

Bazel crashes here while attempting to rewrite test outputs for non-last-attempts

Which category does this issue belong to?

Local Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

  • Have a failing test that creates outputs under nested subdirs
  • Use Bazel that has 489d08b
  • Execute with --flaky_test_attempts=2

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

release 8.0.0rc7

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

489d08b

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

First observed in https://buildkite.com/bazel/clion-plugin/builds/23996#01939224-067c-4206-a972-bac3d852299d
@github-actions github-actions bot added the team-Local-Exec Issues and PRs for the Execution (Local) team label Dec 5, 2024
@hvadehra
Copy link
Member Author

hvadehra commented Dec 5, 2024

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 5, 2024
@hvadehra hvadehra mentioned this issue Dec 5, 2024
Merged
3 tasks
@iancha1992
Copy link
Member

@bazel-io fork 8.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 5, 2024
@bazel-io bazel-io mentioned this issue Dec 5, 2024
Closed
@tjgq tjgq added P1 I'll work on this now. (Assignee required) and removed untriaged labels Dec 6, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Dec 6, 2024
@tjgq @bazel-io
Create intermediate directories when moving deeply nested undeclared …
e3c040f 
…outputs.

Fixes bazelbuild#24578.

PiperOrigin-RevId: 703513880
Change-Id: I3f95a92ead3e64007974e45362185738b5927cee
@bazel-io bazel-io mentioned this issue Dec 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
@bazel-io @tjgq
[8.0.0] Create intermediate directories when moving deeply nested und…
47e5113 
…eclared outputs. (#24594)

Fixes #24578.

PiperOrigin-RevId: 703513880
Change-Id: I3f95a92ead3e64007974e45362185738b5927cee

Commit
d93c1cb

Co-authored-by: Googler <tjgq@google.com>
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 8.0.0 RC8. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=8.0.0rc8. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjgq tjgq

Labels
P1 I'll work on this now. (Assignee required) team-Local-Exec Issues and PRs for the Execution (Local) team type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hvadehra @tjgq @bazel-io @sgowroji @iancha1992 @satyanandak