Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK7 canary binary are named -without-jdk #2969

Closed
damienmg opened this issue May 8, 2017 · 1 comment
Closed

JDK7 canary binary are named -without-jdk #2969

damienmg opened this issue May 8, 2017 · 1 comment
Assignees
@damienmg
Labels
P1 I'll work on this now. (Assignee required) type: bug
Milestone
0.5

Comments

@damienmg
Copy link
Contributor

damienmg commented May 8, 2017

We should not append -without-jdk for the JDK7 variant.
@damienmg damienmg added this to the 0.5 milestone May 8, 2017
@damienmg damienmg added Release blocker type: bug P1 I'll work on this now. (Assignee required) labels May 8, 2017
@damienmg
Copy link
Contributor Author

damienmg commented May 9, 2017 •
edited
Loading

Discussion with @philwo about what to do (TL;DR: we are going to name it -jdk7 and if we are not happy modify the naming scheme further):

@philwo
I don't care much, I guess we could see it as there being three variants "with-jdk", "without-jdk" and "jdk7"?
But at first I thought it was confusing, because if it's not called "without-jdk", then it might look like we're bundling a jdk7?

@damienmg
Yes the current list is weird

@philwo
I'll just LGTM the CL and we can look at the generated files for the next RC and see if they're fine

@damienmg
https://releases.bazel.build/0.5/rc3/index.html --> bazel-0.5rc3-jdk7-without-jdk-installer-darwin-x86_64.sh
That's the only one
since we are going to maintain that code for just one release I believe we should just keep the same name for the JDK7 variant that we were using

@philwo
Ah, yes. Good point.

@damienmg damienmg self-assigned this May 9, 2017
hlopko pushed a commit that referenced this issue May 10, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
6c37ce5 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 10, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
b819f3b 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 10, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
330d345 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 11, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
273108e 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 17, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
975a18a 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 17, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
51188d1 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 23, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
10aacd7 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
damienmg added a commit that referenced this issue May 26, 2017
@damienmg
Do not mark the JDK7 installer -without-jdk-installer
fbfc9e1 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
hlopko pushed a commit that referenced this issue May 31, 2017
@damienmg @hlopko
Do not mark the JDK7 installer -without-jdk-installer
d1b6b21 
Instead just mark it as a default installer when there is
no installer with a bundled JDK.

Fixes #2969
To be cherry-picked for #2692.

PiperOrigin-RevId: 155483548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienmg damienmg

Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@damienmg