Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - February 2018 - Target RC date: 2018-02-01 - name: 0.11.0 #3959

Closed
damienmg opened this issue Oct 24, 2017 · 69 comments
Closed

Release - February 2018 - Target RC date: 2018-02-01 - name: 0.11.0 #3959

damienmg opened this issue Oct 24, 2017 · 69 comments
Assignees
@katre @philwo
Labels
release

Comments

@damienmg
Copy link
Contributor

Release tracking bug for February 2018:

  • Target cut should be 1st of February (first business day of January) but it is close to FOSDEM so we might want to delay
  • Name: 0.11.0

RM if we follow the rotation should be @katre: can you take it?
@dslomov dslomov changed the title Release - February 2018 - Target RC date: 2018-02-0? - name: 0.11.0 Release - February 2018 - Target RC date: 2018-02-01 - name: 0.11.0 Jan 8, 2018
@dslomov
Copy link
Contributor

dslomov commented Jan 8, 2018

@katre - assigning to you for Feb 1. Please lmk if that does not work.

@katre
Copy link
Member

katre commented Jan 8, 2018

I can manage it.

@iirina iirina mentioned this issue Jan 31, 2018
Closed
@iirina
Copy link
Contributor

iirina commented Jan 31, 2018

@katre can you make sure 223ed93 will be included in the RC? I think if you cut from the nightly it should be..

@katre
Copy link
Member

katre commented Jan 31, 2018

I will. I plan to check tomorrow's nightly and cut then.

@katre
Copy link
Member

katre commented Feb 1, 2018

Taking 00d781a as the baseline (from last night's nightly run: https://ci.bazel.build/view/Dashboard/job/bazel/job/nightly/212/)

Next step is to build the RC, then start filing bugs on the test failures.

@katre
Copy link
Member

katre commented Feb 1, 2018

Release note edits:
None.

@katre
Copy link
Member

katre commented Feb 1, 2018

Release is pushed, waiting for https://ci.bazel.build/job/bazel/job/release/1282/ to finish

@katre katre mentioned this issue Feb 1, 2018
Closed
@laszlocsomor
Copy link
Contributor

@katre : Please replace the following in the release notes:

With this:

@laszlocsomor
Copy link
Contributor

Actually, @katre , please remove that entry I mentioned altogether. I discovered a bug about it, filing it now, will update this comment with the bug number.

@katre
Copy link
Member

katre commented Feb 6, 2018

How long will the fix be? I'd prefer to edit the release notes and get your fix cherrypicked along with the fix for #4562 in the next RC.

@laszlocsomor
Copy link
Contributor

I can write the fix tomorrow and, if all goes well, get it submitted tomorrow or the day after.

@katre
Copy link
Member

katre commented Feb 6, 2018

SGTM, thanks.

@laszlocsomor laszlocsomor mentioned this issue Feb 7, 2018
Closed
@laszlocsomor
Copy link
Contributor

@katre : bugfix is out for review (https://bazel-review.googlesource.com/c/bazel/+/37190), we'll need a cherrypick.

@laszlocsomor
Copy link
Contributor

#4598 is a blocker, will need a cherrypick.

@laszlocsomor
Copy link
Contributor

Please cherrypick d855d81 into RC2.

@ola-rozenfeld
Copy link
Contributor

We need to cherrypick 56aeb04, ideally into 0.10.1.

@katre
Copy link
Member

katre commented Feb 8, 2018

@ola-rozenfeld I'll add that to the cherrypick list for 0.11.0rc2. For 0.10.1 you'll need to ping the release issue for 0.10.0, which is #4325 .

@katre
Copy link
Member

katre commented Feb 8, 2018

Current release blocking bugs for 0.11.0:

I'll need to verify the sequencing when all cherrypicks are collected.

@ola-rozenfeld
Copy link
Contributor

ola-rozenfeld commented Feb 8, 2018 via email

@petemounce
Copy link
Contributor

petemounce commented Feb 8, 2018 •
edited
Loading

Pushed

@katre
Copy link
Member

katre commented Feb 8, 2018

Thanks @petemounce!

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Feb 9, 2018 •
edited
Loading

  • There appear to be several commits, but the issue is still open. @laszlocsomor are there more commits coming?

No.

  • d855d81
    • Does not reference the issue, I assume it is related?

Cherry-pick this please.

Bummer. It should reference the bug. That is the bugfix.

No cherry-pick.

This is related, but I don't need you to cherry-pick it; it just adds tests for the bugfix.

No cherry-pick.

This is distantly related; it fixes the same bug in the Python runfiles library as d855d81 did in the Java runfiles library. However 0.11.0 does not contain the original commits for the Py runfils library, so this commit needs not be cherry-picked.

@katre
Copy link
Member

katre commented Feb 9, 2018

Thanks for clarifying!

@katre
Copy link
Member

katre commented Feb 9, 2018 •
edited
Loading

Creating RC2.

$ release.sh create 0.11.0 \
  00d781ae78a8bd51d3c61b621d79f0bb095aff9e \
  ea2d4c4 \
  d855d81 \
  56aeb04

Release note edits: removed section of java runfiles (as per #3959 (comment)).

@katre
Copy link
Member

katre commented Feb 23, 2018

It's also possibly a bug in my bisect script, grump grump...

@ilovezfs
Copy link
Contributor

0.11.0 shipped in Homebrew.

@katre
Copy link
Member

katre commented Feb 23, 2018

@ilovezfs Thanks! I appreciate you working with me to help resolve the issue.

@ilovezfs
Copy link
Contributor

You're welcome!

@buchgr
Copy link
Contributor

buchgr commented Feb 23, 2018

@ilovezfs big thanks ! awesome!

@petemounce
Copy link
Contributor

I think the automation I wrote is affected by https://githubengineering.com/crypto-removal-notice/. I'll fix and push soonest, but not around this weekend.

@petemounce
Copy link
Contributor

Up now at https://chocolatey.org/packages/bazel/0.11.0 via a manual hack.

@buchgr
Copy link
Contributor

buchgr commented Feb 25, 2018

thanks so much @petemounce ... ur work is awesome

@petemounce
Copy link
Contributor

My pleasure :)

@katre
Copy link
Member

katre commented Feb 25, 2018

Thanks very much @petemounce!

With this finished, I am closing the issue for this release.

@katre katre closed this as completed Feb 25, 2018
@katre
Copy link
Member

katre commented Feb 28, 2018

Re-opening to create RC for 0.11.1, cherrypicking fc98b44 to deal with #4736 .

@katre katre reopened this Feb 28, 2018
@katre
Copy link
Member

katre commented Feb 28, 2018

Release command:

release.sh create 0.11.1 \
  00d781ae78a8bd51d3c61b621d79f0bb095aff9e \
  ea2d4c4 \
  d855d81 \
  56aeb04 \
  cf3f81a \
  28bd997 \
  109e4b4 \
  b3d52b1 \
  1001141 \
  fc98b44

@katre
Copy link
Member

katre commented Feb 28, 2018

The release branch is created, but given the current state of our CI system I do not know if Buildkite can create the release artifacts. @philwo and @buchgr , can you comment?

@katre
Copy link
Member

katre commented Mar 1, 2018

Release branch is https://github.com/bazelbuild/bazel/tree/release-0.11.1

@buchgr
Copy link
Contributor

buchgr commented Mar 2, 2018

cc: @vbatts

@vbatts
Copy link

vbatts commented Mar 2, 2018

hey hey! Been a while since you CC'ed, but usually blogtrottr.com does a good job emailing as soon as you tag the releases but didn't get notification of 0.11.0 🤔

https://copr.fedorainfracloud.org/coprs/vbatts/bazel/builds/ has up to 0.10.1

@vbatts
Copy link

vbatts commented Mar 2, 2018

perhaps i'll just jump to 0.11.1 once it's out?

@buchgr
Copy link
Contributor

buchgr commented Mar 2, 2018

@vbatts I apologize. I have just noticed this myself a few hours ago and that's why I pinged you :-). It's up to you. 0.11.1 should be out next week.

We are currently working on a new release process and we'll be able to set it up so that we can automatically send you an e-mail. Again, apologies for not pinging you.

@vbatts
Copy link

vbatts commented Mar 2, 2018 via email

@philwo
Copy link
Member

philwo commented Mar 6, 2018

I'm working to get this pushed as a release, but am currently fighting with our scripts a bit. Sorry for the delay! Hope to get it out by tomorrow.

@philwo
Copy link
Member

philwo commented Mar 6, 2018

I had to recreate the release branch on my machine, as otherwise the script wouldn't let me release it.

Steps:

release.sh create 0.11.1 \
  00d781ae78a8bd51d3c61b621d79f0bb095aff9e \
  ea2d4c4 \
  d855d81 \
  56aeb04 \
  cf3f81a \
  28bd997 \
  109e4b4 \
  b3d52b1 \
  1001141 \
  fc98b44

# Resolve first conflict:
git rm site/docs/remote-caching.md
git cherry-pick --continue; exit

# Resolve second conflict:
vi tools/test/test-setup.sh  # Pick the second version of the conflicting diff.
git add tools/test/test-setup.sh
git cherry-pick --continue; exit

# Edit release notes to read:
Important changes:
  - Fixes regression building Android rules on Windows.

# Push
release.sh push

# Release
release.sh release

Now waiting for CI to build the binaries, will verify that they're fine and will run the release steps for GitHub, GCS and the apt repository then.

@philwo
Copy link
Member

philwo commented Mar 7, 2018 •
edited
Loading

Release was built successfully: https://buildkite.com/bazel/release/builds/11
and released: https://groups.google.com/d/msg/bazel-discuss/lmuaMaYiY-o/r8CCYqO6AAAJ

🎉

@vbatts
Copy link

vbatts commented Mar 7, 2018 via email

@buchgr
Copy link
Contributor

buchgr commented Mar 7, 2018

tyvm @vbatts

@petemounce
Copy link
Contributor

0.11.1 is published to chocolatey.

@buchgr
Copy link
Contributor

buchgr commented Mar 8, 2018

ty @petemounce !

@hlopko hlopko closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

@philwo philwo

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests