Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_disallow_old_style_args_add: Remove deprecated format for Args.add #5822

Closed
c-parsons opened this issue Aug 8, 2018 · 3 comments
Closed

incompatible_disallow_old_style_args_add: Remove deprecated format for Args.add #5822

c-parsons opened this issue Aug 8, 2018 · 3 comments
Assignees
@c-parsons
Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional)

Comments

@c-parsons
Copy link
Contributor

This is a tracking issue for offering a migration solution for
--incompatible_disallow_old_style_args_add
@c-parsons c-parsons self-assigned this Aug 8, 2018
@laurentlb laurentlb added P2 We'll consider working on this in future. (Assignee optional) team-Starlark incompatible-change Incompatible/breaking change and removed category: extensibility > skylark labels Nov 21, 2018
@laurentlb laurentlb changed the title Remove deprecated format for Args.add incompatible_disallow_old_style_args_add: Remove deprecated format for Args.add Jan 9, 2019
@laurentlb
Copy link
Contributor

Only failure on the CI is rules_typescript.

@dslomov
Copy link
Contributor

dslomov commented Jan 31, 2019

@c-parsons when do you intend to flip the flag?

@laurentlb
Copy link
Contributor

I've sent a PR to rules_typescript, still waiting for maintainers to merge it.
I think it will be too late for 0.23, so let's say 0.24.

bazel-io pushed a commit that referenced this issue Nov 8, 2019
@laurentlb @copybara-github
Remove flag incompatible_disallow_old_style_args_add
40d1f45 
#5822

RELNOTES: None.
PiperOrigin-RevId: 279328336
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
Remove flag incompatible_disallow_old_style_args_add
70e7ea4 
    bazelbuild/bazel#5822

    RELNOTES: None.
    PiperOrigin-RevId: 279328336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c-parsons c-parsons

Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurentlb @dslomov @c-parsons