Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolchain dependencies are all in the HOST configuration #6889

Closed
damienmg opened this issue Dec 11, 2018 · 5 comments
Closed

Toolchain dependencies are all in the HOST configuration #6889

damienmg opened this issue Dec 11, 2018 · 5 comments
Assignees
@katre
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@damienmg
Copy link
Contributor

damienmg commented Dec 11, 2018 •
edited
Loading

EDIT: Sorry for the first post, misposted.

See #5650 for more context. I am opening a bug since there is no solution yet and I need to refer to it.

Description of the problem / feature request:

If you add a target dependencies to a toolchain, the dependency ends-up being a host dependencies in the final binary. #5650 contains way more information and a fix for it.
@damienmg
Copy link
Contributor Author

/cc @katre @mhlopko since I already talked to you both about that bug. FTR I have to document why we are not including those dependencies in the toolchain itself

damienmg added a commit to damienmg/rules_rust that referenced this issue Dec 11, 2018
@damienmg
Proto: documentation to change dependencies
cfbcc3f 
Compile dependencies for rust_proto_library and rust_grpc_library
documentation was incorrect. To work-around bazelbuild/bazel#6889,
the format has changed a little but the documentation did not
reflected that change.
@damienmg damienmg mentioned this issue Dec 11, 2018
Merged
damienmg added a commit to bazelbuild/rules_rust that referenced this issue Dec 11, 2018
@damienmg
Proto: documentation to change dependencies (#173)
23ab9d5 
Compile dependencies for rust_proto_library and rust_grpc_library
documentation was incorrect. To work-around bazelbuild/bazel#6889,
the format has changed a little but the documentation did not
reflected that change.

Fixes #170
@katre katre added type: feature request P2 We'll consider working on this in future. (Assignee optional) category: extensibility > toolchains team-Configurability platforms, toolchains, cquery, select(), config transitions labels Dec 11, 2018
@katre
Copy link
Member

katre commented Dec 11, 2018

This is a topic I plan to look into soon, sorry that the backlog has been high.

Several other rule authors have also mentioned this issue, thanks for filing it.

@katre katre self-assigned this Dec 11, 2018
@damienmg damienmg mentioned this issue Jan 1, 2019
Open
@damienmg damienmg mentioned this issue Jan 28, 2019
Merged
@katre
Copy link
Member

katre commented Feb 19, 2019

See https://groups.google.com/forum/#!topic/bazel-dev/5osWxhoF0Fk for the design to address this.

@katre
Copy link
Member

katre commented Jan 6, 2020

Tracking issue for implementing toolchain transitions (finally): #10523.

@katre katre mentioned this issue Feb 3, 2020
Closed
@timblakely timblakely mentioned this issue Feb 10, 2020
Closed
@katre
Copy link
Member

katre commented May 11, 2020

This will be fixed by #7935 and #10523, closing in favor of those issues.

@katre katre closed this as completed May 11, 2020
@UebelAndre UebelAndre mentioned this issue Nov 8, 2020
Closed
@UebelAndre UebelAndre mentioned this issue Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P2 We'll consider working on this in future. (Assignee optional) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katre @damienmg