incompatible_disable_objc_library_resources #7594
Assignees
Labels
incompatible-change
Incompatible/breaking change
Comments
sergiocampama
added
breaking-change-0.24
incompatible-change
|
Please follow the guidance https://www.bazel.build/breaking-changes-guide.html for incompatible changes |
|
@dslomov Updated, thanks for the notification. |
|
I'm not following the migration-0.24 and breaking-change-0.26, what about 0.25? I would like to flip it as soon as I can, could it be done in 0.25? |
|
The issue description says the flag will be flipped for 0.26, so that was what I chose. You can change it to 0.25 if you think all downstream projects will be migrated in time. |
|
I've updated it for 0.25. I'm ok with pushing for this harder deadline for our clients, if that's ok with the Bazel policy |
|
Labels updated. |
bazel-io
pushed a commit
that referenced
this issue
Apr 3, 2019
RELNOTES[INC]: objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. PiperOrigin-RevId: 241782281
|
Can this be closed @sergiocampama ? |
bazel-io
pushed a commit
that referenced
this issue
Apr 13, 2019
RELNOTES: Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See #7594 for details. PiperOrigin-RevId: 243373818
|
it's been flipped to true, but there's cleanup involved... what's the general guidance? should this be closed when the flag is removed? or when it's flipped to true? |
|
Most people tend to close the bug when the flag is flipped (this is the only open bug with "breaking change 0.25 label which is what lead me to ask), but I don't think we actually have guidelines about this so if you want to use the bug to track the cleanup I think that makes a lot of sense :) |
We actually do: https://www.bazel.build/breaking-changes-guide.html#flipping-the-flag |
bazel-io
pushed a commit
that referenced
this issue
Apr 17, 2019
The incompatible flag to disable these resources will be enabled by default in Bazel 0.25. RELNOTES: objc_library does not support resource attributes any more. Please read #7594 for more info. PiperOrigin-RevId: 244026921
bazel-io
pushed a commit
that referenced
this issue
May 1, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
dkelmer
pushed a commit
that referenced
this issue
May 6, 2019
Baseline: 0366246 Cherry picks: + 3f7f255: Windows: fix native test wrapper's arg. escaping + afeb8d0: Flip --incompatible_windows_escape_jvm_flags + 4299b65: Sort DirectoryNode children to ensure validity. + 231270c: Conditionally use deprecated signature for initWithContentsOfURL + 75a3a53: Add http_archive entries for testing with various JDK versions. + 4a6354a: Now that ubuntu1804 uses JDK 11, remove explicit ubuntu1804_java11 tests. + ae102fb: Fix wrong name of ubuntu1804_javabase9 task. + 0020a97: Remove @executable_path/Frameworks from rpaths + 130f86d: Download stderr/stdout to a temporary FileOutErr Incompatible changes: - (Starlark rules) The legacy "py" provider can no longer be passed to or produced by native Python rules; use [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn fo.html) instead. See [#7298](#7298) for more information. - (Python rules) The `default_python_version` attribute of the `py_binary` and `py_test` rules has been renamed to `python_version`. Also, the `--force_python` flag has been renamed to `--python_version`. See [#7308](#7308) for more information. - (Python rules) The python version now changes to whatever version is specified in a `py_binary` or `py_test`'s `python_version` attribute, instead of being forced to the value set by a command line flag. You can temporarily revert this change with `--incompatible_allow_python_version_transitions=false`. See [#7307](#7307) for more information. - --incompatible_disable_third_party_license_checking` is enabled by default - Introduced --incompatible_use_python_toolchains, which supersedes --python_top/--python_path. See #7899 and #7375 for more information. - Python 3 is now the default Python version (for `py_binary` and `py_test` targets that don't specify the `python_version` attribute). Targets that are built for Python 3 will no longer have their output put in a separate `-py3` directory; instead there is now a separate `-py2` directory for Python 2 targets. See #7359 and #7593 for more information. - objc_library resource attributes are now disabled by default. Please migrate them to data instead. See #7594 for more info. - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 New features: - genrules now support a $(RULEDIR) variable that resolves to the directory where the outputs of the rule are put. - Added --incompatible_windows_native_test_wrapper flag: enables using the Bash-less test wrapper on Windows. (No-op on other platforms.) Important changes: - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default --host_javabase for remote jdk (#7219) - Makes genquery somepath output deterministic. - Tristate attributes of native rules now reject True/False (use 1/0) - Rollback of "Tristate attributes of native rules now reject True/False (use 1/0)" - Tristate attributes of native rules now reject True/False (use 1/0) - Added -incompatible_do_not_split_linking_cmdline flag. See #7670 - Tristate attributes of native rules now temporarily accept True/False again - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set... RELNOTES: None. - --incompatible_no_transitive_loads is enabled by default. - Makes TreeArtifact deterministic. - --incompatible_no_transitive_loads is enabled by default. - Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit. - `--incompatible_disable_legacy_crosstool_fields` has been flipped (#6861) `--incompatible_disable_expand_if_all_available_in_flag_set` has been flipped (#7008) - --incompatible_no_transitive_loads is enabled by default. - --incompatible_bzl_disallow_load_after_statement is enabled - Added `--incompatible_require_ctx_in_configure_features`, see #7793 for details. - Flag --incompatible_merge_genfiles_directory is flipped. This removes the directory `bazel-genfiles` in favor of `bazel-bin`. - previously deprecated flag --experimental_remote_spawn_cache was removed - `--incompatible_disallow_load_labels_to_cross_package_boundaries` is enabled by default - Fix an issue where the Android resource processor did not surface errors from aapt2 compile and link actions. - --incompatible_no_attr_license is enabled by default - `--incompatible_disable_crosstool_file` has been flipped (#7320) - A new flag `--incompatible_string_join_requires_strings` is introduced. The sequence argument of `string.join` must contain only string elements. - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile s_tree has been flipped - Incompatible flag `--incompatible_disable_legacy_cc_provider` has been flipped (see #7036 for details). - Don't drop the analysis cache when the same --define flag is set multiple times and the last value is the same (e.g. if the current invocation was run with "--define foo=bar" and the previous one was run with "--define foo=baz --define foo=bar"). - The --incompatible_disable_genrule_cc_toolchain_dependency flag has been flipped (see #6867 for details). - Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha in` has been flipped (see #7075 for details). - --noexperimental_java_coverage is a no-op flag. - --experimental_java_coverage/--incompatible_java_coverage flag was removed. See #7425. - incompatible_use_toolchain_providers_in_java_common: pass JavaToolchainInfo and JavaRuntimeInfo providers to java_common APIs instead of configured targets (#7186.) - --incompatible_remote_symlinks has been flipped. The remote caching and execution protocol will now represent symlinks in outputs as such. See #7917 for more details. - Bazel is now ~20MiB smaller, from unbundling the Android rules' runtime dependencies. This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
pull bot
pushed a commit
to Pandinosaurus/bazel
that referenced
this issue
May 28, 2019
Baseline: daa8ae5 Cherry picks: + 61c7ffa: Automated rollback of commit 87388e2. + 898d7b6: Add test for repository overrides, conflicting with managed directories being added when Bazel server is already started. + c2001a4: Automated rollback of commit bbe47a1. + e67c961: Fix a non-determinism in create_embedded_tools.py. + 81aefe7: Remove unsupported cpu attribute from cc_toolchains. + 597e289: remote: made CombinedCache a composition of Disk and Http Cache + 942f7cf: C++: Fixes bug in C++ API with external repo aspects + 85a5a2b: Configure @androidsdk//:emulator_x86 and :emulator_arm to point to the unified emulator binary + 9835cb4: Automated rollback of commit 844e4e2. + c963ba2: Windows, Python: fix arg. esc. also in host config + a1ea487: Do not pre-cache changed files under managed directories + 7dc78cd: Add explicit execution and target constraints for autodiscovered cc t? + dd9ac13: Fix a bug when a relative path is used for the execution log + 0ff19c6: Fix StandaloneTestStrategy.appendStderr + 7f49531: Fix the autodetecting Python toolchain on Mac + ddce723: Avoid exporting PATH unnecessarily + 35dd05a: Allow Starlark rules to be able to use the `exec_compatible_with` Incompatible changes: - Flip --incompatible_windows_escape_jvm_flags to true. See bazelbuild#7486 - Flip --incompatible_windows_style_arg_escaping to true. See bazelbuild#7454 - --incompatible_windows_escape_jvm_flags is enabled by default, and the flag no longer exists - `--incompatible_no_output_attr_default` is enabled by default. - --incompatible_depset_union is enabled by default. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See [bazelbuild#7899](bazelbuild#7899) for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See bazelbuild#7899 for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. New features: - Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping. - cquery supports --output=build Important changes: - Allow debugging C++ features logic. - The --ios_multi_cpus, --watchos_cpus, --macos_cpus and tvos_cpus are now additive. This means that you can now split the --ios_multi_cpus=arm64,armv7 into --ios_multi_cpus=arm64 and --ios_multi_cpus=armv7. - Generated Go protobufs now depend on //net/proto2/go:proto_gendeps instead of //net/proto2/go:proto - Add new options --cs_fdo_instrument and --cs_profile to support LLVM's context-sensitive FDO (CSFDO). - Bazel C++ compile/link Starlark API. Can be used with experimental flag --experimental_cc_skylark_api_enabled_packages=<package_path>,<pac kage_path2>. - `cc_toolchain.static_runtime_lib` and `cc_toolchain.dynamic_runtime_lib` are now exposed to Starlark. - New flag `--incompatible_no_kwargs_in_build_files`. See bazelbuild#8021 - struct.to_proto() converts dict into proto3 text message (map<,>). - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Flag `--incompatible_static_name_resolution_in_build_files` is added. See bazelbuild#8022 - Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See bazelbuild#7594 for details. - Added --incompatible_remove_binary_profile to disable the old binary profiles. Instead use the JSON profile format: https://docs.bazel.build/versions/master/skylark/performance.html# json-profile - Introducing --execution_log_binary_file and --execution_log_json_file that output a stable sorted execution log. They will offer a stable replacement to --experimental_execution_log_file. - Flag `--incompatible_disallow_old_octal_notation` is added. See //github.com/bazelbuild/issues/8059 - Removes the --incompatible_disable_genrule_cc_toolchain_dependency flag. - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Incompatible flag `--incompatible_make_thinlto_command_lines_standalone` has been added. See bazelbuild#6791 for details. - objc_library does not support resource attributes any more. Please read bazelbuild#7594 for more info. - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. - New platform_mappings ability to allow gradual flag to platforms/toolchains migration. See also bazelbuild#6426 - Added support for compiling against fully qualified R classes from aar_import dependencies. - --tls_enabled flag is deprecated. Please provide 'grpcs' as a scheme in the URLs if TLS should be used for a remote connection. - Adds incompatible_disallow_rule_execution_platform_constraints_allowed, which disallows the use of the "execution_platform_constraints_allowed" attribute when defining new rules. - Flag `--incompatible_restrict_named_params` is added. See bazelbuild#8147 for details. - The glob function has a new argument `allow_empty`. When set to False, the glob fails when it doesn't match anything. - Adds the "disable_whole_archive_for_static_lib" feature to allow turning off legacy_whole_archive for individual targets. - C++ Starlark API for compilation and linking is no longer whitelisted - Update visibility advice in build-style - --incompatible_disable_objc_provider_resources is now enabled by default. - Fixed an issue where some `py_runtime`s were incompatible with using `--build_python_zip` (bazelbuild#5104). - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. This release contains contributions from many people at Google, as well as Benjamin Peterson, Brian Topping, clyang82, Dave Lee, George Gensure, Greg Estren, Greg, Guro Bokum, Keith Smiley, Max Vorobev, Michael Hackner, Robert Brown, Robert Sayre, Ryan Beasley, Yannic.
aehlig
pushed a commit
that referenced
this issue
Jun 3, 2019
Baseline: daa8ae5 Cherry picks: + 61c7ffa: Automated rollback of commit 87388e2. + 898d7b6: Add test for repository overrides, conflicting with managed directories being added when Bazel server is already started. + c2001a4: Automated rollback of commit bbe47a1. + e67c961: Fix a non-determinism in create_embedded_tools.py. + 81aefe7: Remove unsupported cpu attribute from cc_toolchains. + 597e289: remote: made CombinedCache a composition of Disk and Http Cache + 942f7cf: C++: Fixes bug in C++ API with external repo aspects + 85a5a2b: Configure @androidsdk//:emulator_x86 and :emulator_arm to point to the unified emulator binary + 9835cb4: Automated rollback of commit 844e4e2. + c963ba2: Windows, Python: fix arg. esc. also in host config + a1ea487: Do not pre-cache changed files under managed directories + 7dc78cd: Add explicit execution and target constraints for autodiscovered cc t? + dd9ac13: Fix a bug when a relative path is used for the execution log + 0ff19c6: Fix StandaloneTestStrategy.appendStderr + 7f49531: Fix the autodetecting Python toolchain on Mac + ddce723: Avoid exporting PATH unnecessarily + 35dd05a: Allow Starlark rules to be able to use the `exec_compatible_with` Incompatible changes: - Flip --incompatible_windows_escape_jvm_flags to true. See #7486 - Flip --incompatible_windows_style_arg_escaping to true. See #7454 - --incompatible_windows_escape_jvm_flags is enabled by default, and the flag no longer exists - `--incompatible_no_output_attr_default` is enabled by default. - --incompatible_depset_union is enabled by default. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See [#7899](#7899) for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses #4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See #7899 for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses #4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. New features: - Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping. - cquery supports --output=build Important changes: - Allow debugging C++ features logic. - The --ios_multi_cpus, --watchos_cpus, --macos_cpus and tvos_cpus are now additive. This means that you can now split the --ios_multi_cpus=arm64,armv7 into --ios_multi_cpus=arm64 and --ios_multi_cpus=armv7. - Generated Go protobufs now depend on //net/proto2/go:proto_gendeps instead of //net/proto2/go:proto - Add new options --cs_fdo_instrument and --cs_profile to support LLVM's context-sensitive FDO (CSFDO). - Bazel C++ compile/link Starlark API. Can be used with experimental flag --experimental_cc_skylark_api_enabled_packages=<package_path>,<pac kage_path2>. - `cc_toolchain.static_runtime_lib` and `cc_toolchain.dynamic_runtime_lib` are now exposed to Starlark. - New flag `--incompatible_no_kwargs_in_build_files`. See #8021 - struct.to_proto() converts dict into proto3 text message (map<,>). - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Flag `--incompatible_static_name_resolution_in_build_files` is added. See #8022 - Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See #7594 for details. - Added --incompatible_remove_binary_profile to disable the old binary profiles. Instead use the JSON profile format: https://docs.bazel.build/versions/master/skylark/performance.html# json-profile - Introducing --execution_log_binary_file and --execution_log_json_file that output a stable sorted execution log. They will offer a stable replacement to --experimental_execution_log_file. - Flag `--incompatible_disallow_old_octal_notation` is added. See //github.com//issues/8059 - Removes the --incompatible_disable_genrule_cc_toolchain_dependency flag. - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Incompatible flag `--incompatible_make_thinlto_command_lines_standalone` has been added. See #6791 for details. - objc_library does not support resource attributes any more. Please read #7594 for more info. - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See #7977 for more info. - New platform_mappings ability to allow gradual flag to platforms/toolchains migration. See also #6426 - Added support for compiling against fully qualified R classes from aar_import dependencies. - --tls_enabled flag is deprecated. Please provide 'grpcs' as a scheme in the URLs if TLS should be used for a remote connection. - Adds incompatible_disallow_rule_execution_platform_constraints_allowed, which disallows the use of the "execution_platform_constraints_allowed" attribute when defining new rules. - Flag `--incompatible_restrict_named_params` is added. See #8147 for details. - The glob function has a new argument `allow_empty`. When set to False, the glob fails when it doesn't match anything. - Adds the "disable_whole_archive_for_static_lib" feature to allow turning off legacy_whole_archive for individual targets. - C++ Starlark API for compilation and linking is no longer whitelisted - Update visibility advice in build-style - --incompatible_disable_objc_provider_resources is now enabled by default. - Fixed an issue where some `py_runtime`s were incompatible with using `--build_python_zip` (#5104). - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See #7977 for more info. This release contains contributions from many people at Google, as well as Benjamin Peterson, Brian Topping, clyang82, Dave Lee, George Gensure, Greg Estren, Greg, Guro Bokum, Keith Smiley, Max Vorobev, Michael Hackner, Robert Brown, Robert Sayre, Ryan Beasley, Yannic.
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jun 18, 2019
Baseline: daa8ae5 Cherry picks: + 61c7ffa: Automated rollback of commit 87388e2. + 898d7b6: Add test for repository overrides, conflicting with managed directories being added when Bazel server is already started. + c2001a4: Automated rollback of commit bbe47a1. + e67c961: Fix a non-determinism in create_embedded_tools.py. + 81aefe7: Remove unsupported cpu attribute from cc_toolchains. + 597e289: remote: made CombinedCache a composition of Disk and Http Cache + 942f7cf: C++: Fixes bug in C++ API with external repo aspects + 85a5a2b: Configure @androidsdk//:emulator_x86 and :emulator_arm to point to the unified emulator binary + 9835cb4: Automated rollback of commit 844e4e2. + c963ba2: Windows, Python: fix arg. esc. also in host config + a1ea487: Do not pre-cache changed files under managed directories + 7dc78cd: Add explicit execution and target constraints for autodiscovered cc t? + dd9ac13: Fix a bug when a relative path is used for the execution log + 0ff19c6: Fix StandaloneTestStrategy.appendStderr + 7f49531: Fix the autodetecting Python toolchain on Mac + ddce723: Avoid exporting PATH unnecessarily + 35dd05a: Allow Starlark rules to be able to use the `exec_compatible_with` Incompatible changes: - Flip --incompatible_windows_escape_jvm_flags to true. See bazelbuild#7486 - Flip --incompatible_windows_style_arg_escaping to true. See bazelbuild#7454 - --incompatible_windows_escape_jvm_flags is enabled by default, and the flag no longer exists - `--incompatible_no_output_attr_default` is enabled by default. - --incompatible_depset_union is enabled by default. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See [bazelbuild#7899](bazelbuild#7899) for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See bazelbuild#7899 for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. New features: - Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping. - cquery supports --output=build Important changes: - Allow debugging C++ features logic. - The --ios_multi_cpus, --watchos_cpus, --macos_cpus and tvos_cpus are now additive. This means that you can now split the --ios_multi_cpus=arm64,armv7 into --ios_multi_cpus=arm64 and --ios_multi_cpus=armv7. - Generated Go protobufs now depend on //net/proto2/go:proto_gendeps instead of //net/proto2/go:proto - Add new options --cs_fdo_instrument and --cs_profile to support LLVM's context-sensitive FDO (CSFDO). - Bazel C++ compile/link Starlark API. Can be used with experimental flag --experimental_cc_skylark_api_enabled_packages=<package_path>,<pac kage_path2>. - `cc_toolchain.static_runtime_lib` and `cc_toolchain.dynamic_runtime_lib` are now exposed to Starlark. - New flag `--incompatible_no_kwargs_in_build_files`. See bazelbuild#8021 - struct.to_proto() converts dict into proto3 text message (map<,>). - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Flag `--incompatible_static_name_resolution_in_build_files` is added. See bazelbuild#8022 - Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See bazelbuild#7594 for details. - Added --incompatible_remove_binary_profile to disable the old binary profiles. Instead use the JSON profile format: https://docs.bazel.build/versions/master/skylark/performance.html# json-profile - Introducing --execution_log_binary_file and --execution_log_json_file that output a stable sorted execution log. They will offer a stable replacement to --experimental_execution_log_file. - Flag `--incompatible_disallow_old_octal_notation` is added. See //github.com/bazelbuild/issues/8059 - Removes the --incompatible_disable_genrule_cc_toolchain_dependency flag. - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Incompatible flag `--incompatible_make_thinlto_command_lines_standalone` has been added. See bazelbuild#6791 for details. - objc_library does not support resource attributes any more. Please read bazelbuild#7594 for more info. - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. - New platform_mappings ability to allow gradual flag to platforms/toolchains migration. See also bazelbuild#6426 - Added support for compiling against fully qualified R classes from aar_import dependencies. - --tls_enabled flag is deprecated. Please provide 'grpcs' as a scheme in the URLs if TLS should be used for a remote connection. - Adds incompatible_disallow_rule_execution_platform_constraints_allowed, which disallows the use of the "execution_platform_constraints_allowed" attribute when defining new rules. - Flag `--incompatible_restrict_named_params` is added. See bazelbuild#8147 for details. - The glob function has a new argument `allow_empty`. When set to False, the glob fails when it doesn't match anything. - Adds the "disable_whole_archive_for_static_lib" feature to allow turning off legacy_whole_archive for individual targets. - C++ Starlark API for compilation and linking is no longer whitelisted - Update visibility advice in build-style - --incompatible_disable_objc_provider_resources is now enabled by default. - Fixed an issue where some `py_runtime`s were incompatible with using `--build_python_zip` (bazelbuild#5104). - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. This release contains contributions from many people at Google, as well as Benjamin Peterson, Brian Topping, clyang82, Dave Lee, George Gensure, Greg Estren, Greg, Guro Bokum, Keith Smiley, Max Vorobev, Michael Hackner, Robert Brown, Robert Sayre, Ryan Beasley, Yannic.
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jul 15, 2019
Baseline: daa8ae5 Cherry picks: + 61c7ffa: Automated rollback of commit 87388e2. + 898d7b6: Add test for repository overrides, conflicting with managed directories being added when Bazel server is already started. + c2001a4: Automated rollback of commit bbe47a1. + e67c961: Fix a non-determinism in create_embedded_tools.py. + 81aefe7: Remove unsupported cpu attribute from cc_toolchains. + 597e289: remote: made CombinedCache a composition of Disk and Http Cache + 942f7cf: C++: Fixes bug in C++ API with external repo aspects + 85a5a2b: Configure @androidsdk//:emulator_x86 and :emulator_arm to point to the unified emulator binary + 9835cb4: Automated rollback of commit 844e4e2. + c963ba2: Windows, Python: fix arg. esc. also in host config + a1ea487: Do not pre-cache changed files under managed directories + 7dc78cd: Add explicit execution and target constraints for autodiscovered cc t? + dd9ac13: Fix a bug when a relative path is used for the execution log + 0ff19c6: Fix StandaloneTestStrategy.appendStderr + 7f49531: Fix the autodetecting Python toolchain on Mac + ddce723: Avoid exporting PATH unnecessarily + 35dd05a: Allow Starlark rules to be able to use the `exec_compatible_with` Incompatible changes: - Flip --incompatible_windows_escape_jvm_flags to true. See bazelbuild#7486 - Flip --incompatible_windows_style_arg_escaping to true. See bazelbuild#7454 - --incompatible_windows_escape_jvm_flags is enabled by default, and the flag no longer exists - `--incompatible_no_output_attr_default` is enabled by default. - --incompatible_depset_union is enabled by default. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See [bazelbuild#7899](bazelbuild#7899) for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. - Python rules now determine the Python runtime using toolchains rather than `--python_top` and `--python_path`, which are deprecated. See bazelbuild#7899 for information on declaring Python toolchains and migrating your code. As a side-benefit, this addresses bazelbuild#4815 (incorrect interpreter version used) on non-Windows platforms. You can temporarily opt out of this change with `--incompatible_use_python_toolchains=false`. New features: - Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping. - cquery supports --output=build Important changes: - Allow debugging C++ features logic. - The --ios_multi_cpus, --watchos_cpus, --macos_cpus and tvos_cpus are now additive. This means that you can now split the --ios_multi_cpus=arm64,armv7 into --ios_multi_cpus=arm64 and --ios_multi_cpus=armv7. - Generated Go protobufs now depend on //net/proto2/go:proto_gendeps instead of //net/proto2/go:proto - Add new options --cs_fdo_instrument and --cs_profile to support LLVM's context-sensitive FDO (CSFDO). - Bazel C++ compile/link Starlark API. Can be used with experimental flag --experimental_cc_skylark_api_enabled_packages=<package_path>,<pac kage_path2>. - `cc_toolchain.static_runtime_lib` and `cc_toolchain.dynamic_runtime_lib` are now exposed to Starlark. - New flag `--incompatible_no_kwargs_in_build_files`. See bazelbuild#8021 - struct.to_proto() converts dict into proto3 text message (map<,>). - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Flag `--incompatible_static_name_resolution_in_build_files` is added. See bazelbuild#8022 - Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See bazelbuild#7594 for details. - Added --incompatible_remove_binary_profile to disable the old binary profiles. Instead use the JSON profile format: https://docs.bazel.build/versions/master/skylark/performance.html# json-profile - Introducing --execution_log_binary_file and --execution_log_json_file that output a stable sorted execution log. They will offer a stable replacement to --experimental_execution_log_file. - Flag `--incompatible_disallow_old_octal_notation` is added. See //github.com/bazelbuild/issues/8059 - Removes the --incompatible_disable_genrule_cc_toolchain_dependency flag. - Android resource conflicts will no longer be reported between a strong attr resource and a weak attr resource, if the weak attr does not have format specified. - Incompatible flag `--incompatible_make_thinlto_command_lines_standalone` has been added. See bazelbuild#6791 for details. - objc_library does not support resource attributes any more. Please read bazelbuild#7594 for more info. - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. - New platform_mappings ability to allow gradual flag to platforms/toolchains migration. See also bazelbuild#6426 - Added support for compiling against fully qualified R classes from aar_import dependencies. - --tls_enabled flag is deprecated. Please provide 'grpcs' as a scheme in the URLs if TLS should be used for a remote connection. - Adds incompatible_disallow_rule_execution_platform_constraints_allowed, which disallows the use of the "execution_platform_constraints_allowed" attribute when defining new rules. - Flag `--incompatible_restrict_named_params` is added. See bazelbuild#8147 for details. - The glob function has a new argument `allow_empty`. When set to False, the glob fails when it doesn't match anything. - Adds the "disable_whole_archive_for_static_lib" feature to allow turning off legacy_whole_archive for individual targets. - C++ Starlark API for compilation and linking is no longer whitelisted - Update visibility advice in build-style - --incompatible_disable_objc_provider_resources is now enabled by default. - Fixed an issue where some `py_runtime`s were incompatible with using `--build_python_zip` (bazelbuild#5104). - The `outputs` parameter of the `rule()` function is deprecated and attached to flag `--incompatible_no_rule_outputs_param`. Migrate rules to use `OutputGroupInfo` or `attr.output` instead. See bazelbuild#7977 for more info. This release contains contributions from many people at Google, as well as Benjamin Peterson, Brian Topping, clyang82, Dave Lee, George Gensure, Greg Estren, Greg, Guro Bokum, Keith Smiley, Max Vorobev, Michael Hackner, Robert Brown, Robert Sayre, Ryan Beasley, Yannic.
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this issue
Sep 4, 2022
RELNOTES: Add --incompatible_objc_framework_cleanup to control whether to enable some objc framework cleanup that changes the API. Specifically, the cleanup changes the objc provider API pertaining to frameworks. This change is expected to be transparent to most users unless they write their own Starlark rules to handle frameworks. See bazelbuild/bazel#7594 for details. PiperOrigin-RevId: 243373818
luca-digrazia
pushed a commit
to luca-digrazia/DatasetCommitsDiffSearch
that referenced
this issue
Sep 4, 2022
RELNOTES[INC]: objc_library resource attributes are now disabled by default. Please migrate them to data instead. See bazelbuild/bazel#7594 for more info. PiperOrigin-RevId: 241782281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
objc_libraryresource attributes are deprecated and will be removed. Refer to the Resources guide for more information on using resources for Apple platform targets.In short, the following attributes are marked as deprecated:
asset_catalogsbundlesdatamodelsresourcesstoryboardsstringsstructured_resourcesxibsMost of these attributes can be directly moved to the
dataattribute, except thestructured_resourcesones. Please refer to the Resources guide for more information.Expected timeline:
The text was updated successfully, but these errors were encountered: