Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Python tests run under Windows #8411

Closed
brandjon opened this issue May 20, 2019 · 0 comments
Closed

Ensure Python tests run under Windows #8411

brandjon opened this issue May 20, 2019 · 0 comments
Assignees
@brandjon
Labels
P1 I'll work on this now. (Assignee required) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

We currently disable some Python tests under Windows because until recently our CI machines didn't have both Python 2 and Python 3 available. Now that that's resolved, we should enable them.

P1 because this blocks fixing #7947, which in turn is needed to enable toolchains on Windows.

Separate from #6868, which concerns adding or OSSing test cases.
@brandjon brandjon added P1 I'll work on this now. (Assignee required) type: process team-Rules-Python Native rules for Python labels May 20, 2019
@brandjon brandjon self-assigned this May 20, 2019
@brandjon brandjon mentioned this issue May 22, 2019
Closed
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@brandjon @irengrig
Enable Python integration tests on Windows
7daa1fd 
Now that we have both a Python 2 and 3 interpreter on our CI machines (bazelbuild/continuous-integration#578), we can turn on these version tests for Windows. Since there's no autodetecting toolchain for Windows yet (bazelbuild#7844) we define an explicit toolchain.

Fixes bazelbuild#8411.

RELNOTES: None
PiperOrigin-RevId: 250562174
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@brandjon @irengrig
Enable Python integration tests on Windows
10840c4 
Now that we have both a Python 2 and 3 interpreter on our CI machines (bazelbuild/continuous-integration#578), we can turn on these version tests for Windows. Since there's no autodetecting toolchain for Windows yet (bazelbuild#7844) we define an explicit toolchain.

Fixes bazelbuild#8411.

RELNOTES: None
PiperOrigin-RevId: 250562174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandjon brandjon

Labels
P1 I'll work on this now. (Assignee required) team-Rules-Python Native rules for Python type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandjon