-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP's named set of files is incomplete if an action from any output group of a set of groups fails #9413
Comments
See simplified repro here: https://github.com/jin/repro/tree/master/9413 |
Quick mention that this is very important for the IntelliJ plugin, both for Blaze and Bazel users. The workaround of running separate builds (which we don't do, and which would require significant work) causes serious performance regressions when running remotely, so isn't a good option. |
The semantics you describe seem reasonable. Unless it's overly invasive, it seems reasonable to change the implementation to match. I haven't looked at the code. |
Moving this over to the Bazel Core team. |
(adgar@ is looking at this) |
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
Any updates? |
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
…ith info only This is to make sure we have the needed metadata even if build broke Relates to: bazelbuild#1167 bazelbuild/bazel#9413 Fix test
Let T be a target,
foo-outputs
andbar-outputs
be output groups,foo-action
andbar-action
be actions in T, andfoo.out
andbar.out
be outputs generated byfoo-action
andbar-action
respectively.foo-outputs
, we expectfoo.out
to be in aNamedSetOfFiles
in the BEP output. This is WAI.foo-outputs
andbar-outputs
, we expectfoo.out
andbar.out
to be in in their ownNamedSetOfFiles
, since they were generated by different actionsfoo-action
andbar-action
. This is WAI.foo-outputs
andbar-outputs
, andbar-action
fails, we expect thatfoo.out
to still be listed in BEP. However, this is not the case andfoo.out
is missing, even with--keep_going
.foo-outputs
files will also be missing from the BEP.This has caused issues with IJwB's Java integration. See this issue for the diagnosis and a repro project. bazelbuild/intellij#1167 (comment)
The intuitive BEP state here is that the
foo-outputs
files should still be listed, regardless of failing actions requested by other output groups.The text was updated successfully, but these errors were encountered: