Add READ access of mmap() in docker env #10761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In docker multi-architecture environment, calling the mmap() with only PROT_WRITE would fail the following write(). Adding PROT_READ access would solve the issue. The logic there only needs WRITE access, however, it should be fine to assign READ access too. Actually, PROT_WRITE is offen implementated as PROT_READ|PROT_WRITE. fix: bazelbuild#7135. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
|
I verified this fix on: and and used the |
aiuto
added
the
team-OSS
|
@philwo I'm not really sure if this is your area right now. It seems to be correct to me, but I'm not sure who really owns ijar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In docker multi-architecture environment, calling the
mmap() with only PROT_WRITE would fail the following
write(). Adding PROT_READ access would solve the issue.
The logic there only needs WRITE access, however, it
should be fine to assign READ access too. Actually,
PROT_WRITE is offen implementated as PROT_READ|PROT_WRITE.
fix: #7135.
Signed-off-by: Yihong Wang yh.wang@ibm.com