Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third party libraries necessary for Android databinding. #10795

Closed
wants to merge 8 commits into from
Closed

Add third party libraries necessary for Android databinding. #10795

wants to merge 8 commits into from

Conversation

ahumesky
Copy link
Contributor

@ahumesky ahumesky commented Feb 14, 2020

  1. Updates databinding to 3.4.0
  2. Updates gson to 2.8.0
  3. All other libraries are added:
third_party/animal_sniffer/animal-sniffer-annotations-1.14.jar
third_party/apache_commons_codec/commons-codec-1.10.jar
third_party/java/j2objc-annotations/j2objc-annotations-1.1.jar
third_party/javax_activation/javax.activation-api-1.2.0.jar
third_party/jaxb/2.3.0/jaxb-api-2.3.0.jar
third_party/jaxb/2.3.0/jaxb-core-2.3.0.jar
third_party/jaxb/2.3.0/jaxb-impl-2.3.0.jar
third_party/jetbrains_annotations/annotations-13.0.jar
third_party/jetifier/jetifier-core-1.0.0-beta04.jar
third_party/juniversalchardet/juniversalchardet-1.0.3.jar
third_party/kotlin_stdlib/kotlin-stdlib-1.3.21.jar
third_party/kotlin_stdlib/kotlin-stdlib-common-1.3.21.jar
third_party/kotlin_stdlib/kotlin-stdlib-jdk7-1.3.21.jar
third_party/kotlin_stdlib/kotlin-stdlib-jdk8-1.3.21.jar

Necessary for #2694.

Note that none of the added dependencies become part of bazel: The new dependencies become part of the android remote tools, which are hosted in a separate download. The tools are just built out of bazel's repo, which is why these dependencies are being added here.

1. Updates databinding to v3.4.0
2. Updates gson to 2.8.0
3. All other libraries are added

Necessary for #2694.
@jin jin added the team-Android Issues for Android team label Feb 28, 2020
@ahumesky ahumesky marked this pull request as ready for review June 11, 2020 02:46
@ahumesky ahumesky requested review from philwo and meisterT June 11, 2020 02:56
@philwo
Copy link
Member

philwo commented Jun 19, 2020

Sorry for the delay. I'm merging this now.

@philwo
Copy link
Member

philwo commented Jun 19, 2020

@ahumesky I'm getting a merge-conflict on the third_party/BUILD file. Could you please rebase this against master?

@philwo
Copy link
Member

philwo commented Jun 23, 2020

Rebased, squashed and merged via #11629 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants