-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add third party libraries necessary for Android databinding. #10795
Closed
ahumesky
wants to merge
8
commits into
bazelbuild:master
from
ahumesky:addDatabindingThirdPartyLibraries
Closed
Add third party libraries necessary for Android databinding. #10795
ahumesky
wants to merge
8
commits into
bazelbuild:master
from
ahumesky:addDatabindingThirdPartyLibraries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Updates databinding to v3.4.0 2. Updates gson to 2.8.0 3. All other libraries are added Necessary for #2694.
meisterT
approved these changes
Jun 12, 2020
jin
approved these changes
Jun 15, 2020
Sorry for the delay. I'm merging this now. |
@ahumesky I'm getting a merge-conflict on the |
Rebased, squashed and merged via #11629 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for #2694.
Note that none of the added dependencies become part of bazel: The new dependencies become part of the android remote tools, which are hosted in a separate download. The tools are just built out of bazel's repo, which is why these dependencies are being added here.