Stop doing actions.write UTF-8. This was causing a double encode. #11496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Bazel reads BUILD and .bzl files as (essentially) raw bytes, any UTF-8 encoded input is essentially pre-UTF-8 encoded on the way out. Closes bazelbuild#10174 DO NOT SUBMIT: This is a breaking change, so it needs a migration path. Current idea: - introduce a new attribute to write 'encode_as_utf_8'. Default is gated by incompatible_write_action_encodes_as_utf_8. - for bazel we do the multi-release cycle flip - for google we agressively try to change the default - add encode_as_utf_8 to the few broken rules - flip the default - fix the user.
|
Done in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Bazel reads BUILD and .bzl files as (essentially) raw bytes, any UTF-8
encoded input is essentially pre-UTF-8 encoded on the way out.
Closes #10174
DO NOT SUBMIT: This is a breaking change, so it needs a migration path.
Current idea: