[Do Not Review]fix common prefix for instrumentation filter

[caiyulun]

fix #10949, we should remove nested filter only if it is a subpath of another filter.

[ulfjack]

Please add a test if possible, and also link to a bug - if there is one already, great, otherwise please file a bug.

[caiyulun]

Please add a test if possible, and also link to a bug - if there is one already, great, otherwise please file a bug.

Thanks, I'm working on unit test now.

[meisterT]

What's the state of this PR?

[jin]

Assigning back to the PR author to add tests.

[philwo]

We're replacing the "WIP" label with the native GitHub "draft PRs". I thus converted this PR to a draft.

Please mark this as ready for review when it's ready, or close it if you no longer intend to work on it. Thanks! 👍

[limdor]

Any status in this PR? Any objections if I add some tests to it and submit a PR? Maybe I will regret my words but should not be hard to add a test here.

[philwo]

@c-mita Is this something you could help with? (Just checked who touched this file last and it was you. ;))

[c-mita]

This looks reasonable to me. Unfortunately the test cases for this class are internal (I don't know if there's anything blocking them from being open-sourced or if it's just a question of effort and time).

If you could add a single test case for the issue you're fixing that can be transplanted into the internal suite, that would be great. We did this for #11971.

[limdor]

@c-mita I tried to add them but I got blocked. I added a description on the original issue ticket. Maybe you know the answer? #10949

[aiuto]

Friendly ping

[limdor]

I think this can be closed, see
#10949 and the pr associated to it limdor@2dad806

[aiuto]

Thanks.

…

On Thu, Oct 7, 2021 at 6:01 PM Xavier Bonaventura ***@***.***> wrote: I think this can be closed, see #10949 <#10949> and the pr associated to it — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11690 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHDG7IIAPCEUE6PISQTUFYKDHANCNFSM4ONOX6TQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.