Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up how android repos end in the distfile #11744

Closed
wants to merge 3 commits into from
Closed

Clean up how android repos end in the distfile #11744

wants to merge 3 commits into from

Conversation

katre
Copy link
Member

@katre katre commented Jul 10, 2020

Three changes:

  1. Use tools/android/BUILD.tools instead of tools/android/BUILD in the distfile.
  2. Re-comment android_sdk_repository and android_ndk_repository (they aren't needed for bootstrapping).
  3. Fix srcs_test to handle the case where part of the distfile is generated by a genrule.

@katre katre requested a review from brandjon July 10, 2020 15:46
@katre katre force-pushed the distfile-clean-android-repos branch from aeaeb67 to 985a8a7 Compare July 13, 2020 12:48
@katre katre requested review from jin and ahumesky and removed request for brandjon July 13, 2020 13:56
@bazel-io bazel-io closed this in 1e00502 Jul 20, 2020
@katre katre deleted the distfile-clean-android-repos branch July 20, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michajlo michajlo michajlo approved these changes

@jin jin Awaiting requested review from jin

@ahumesky ahumesky Awaiting requested review from ahumesky

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katre @michajlo @googlebot