Make processing of paths with tilde consistent between client and server #11987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PathFragmentConverter in Java expands ~ to the user home directory. Path arguments processed in client behave strangely compared to arguments processed in Java: `startup --output_user_root=~/test` actually expands to `WORKSPACE_ROOT/~/test`. This patch changes AbsolutePathFromFlag to expand ~ suffixes
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
chancila
changed the title
oquenchil
added
the
team-OSS
|
friendly ping |
Yannic
pushed a commit
to Yannic/bazel
that referenced
this pull request
Oct 5, 2020
PathFragmentConverter in Java expands ~ to the user home directory. Startup arguments that contain paths with `~` processed in client behave strangely compared to arguments processed in Java: `startup --output_user_root=~/test` actually expands to `WORKSPACE_ROOT/~/test`. Change AbsolutePathFromFlag to expand `~` suffixes to the user's home directory. Closes bazelbuild#11987. PiperOrigin-RevId: 333304795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathFragmentConverter in Java expands ~ to the user home directory.
Startup arguments that contain paths with
~processed in client behave strangely compared to arguments processed in Java:startup --output_user_root=~/testactually expands toWORKSPACE_ROOT/~/test.Change AbsolutePathFromFlag to expand
~suffixes to the user's home directory.