Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3] Bump grpc to 1.32.x to fix a too_many_pings regression #12289

Closed

Conversation

dmivankov
Copy link
Contributor

Part 3: remove 1.31.1 from third_party/grpc

grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which started failing in RBE with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings

grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings

Hopefully version bump to those helps

#12264

Note: also an attempt and disabling auto flow by default is made in
#12266

Part 3: remove 1.31.1 from third_party/grpc

grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which  started failing in RBE with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings

grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings

Hopefully version bump to those helps

bazelbuild#12264

Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@aiuto aiuto added the area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling label Oct 16, 2020
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in f6a1805 Oct 19, 2020
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request Oct 22, 2020
Part 3: remove 1.31.1 from third_party/grpc

grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which  started failing in RBE with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings

grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings

Hopefully version bump to those helps

bazelbuild#12264

Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266

Closes bazelbuild#12289
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request Oct 22, 2020
Part 3: remove 1.31.1 from third_party/grpc

grpc-java transition from v1.26.0 to v1.31.1 enabled auto flow control
which  started failing in RBE with

io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Bandwidth exhausted
HTTP/2 error code: ENHANCE_YOUR_CALM
Received Goaway
too_many_pings

grpc-java v1.32.2 has a bugfix attempt on that
grpc v1.32.0 also has something new around keepalive pings

Hopefully version bump to those helps

bazelbuild#12264

Note: also an attempt and disabling auto flow by default is made in
bazelbuild#12266

Closes bazelbuild#12289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants