Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty argument in repository_ctx.which() #12436

Closed
wants to merge 1 commit into from
Closed

Handle empty argument in repository_ctx.which() #12436

wants to merge 1 commit into from

Conversation

mai12
Copy link
Contributor

@mai12 mai12 commented Nov 9, 2020

This PR handles empty program name in repository_ctx.which() to fix #12216

@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@mai93 mai93 changed the title Handle empty argument in repository_ctx. which Handle empty argument in repository_ctx.which() Nov 9, 2020
@mai93 mai93 requested a review from philwo November 9, 2020 15:29
@oquenchil oquenchil added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 16, 2020
@bazel-io bazel-io closed this in ddcf5f7 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwo philwo philwo approved these changes

Assignees

@philwo philwo

Labels
cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starlark crashes evaluating repository_ctx.which("")
4 participants
@mai12 @philwo @oquenchil @mai93