Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the java_tools release split into platform independent and prebuilt part. #12552

Closed
wants to merge 13 commits into from
Closed

Use the java_tools release split into platform independent and prebuilt part. #12552

wants to merge 13 commits into from

Commits on Nov 26, 2020

  1. Separate java_tools into platform independent and prebuilt part. 

    java_tools is package containing tools needed during Java compilation: JavaBuilder, patches for Java compiler, ijar, singlejar, ...
Most of the files are pure Java .jars. java_tools are released for three platforms: linux, windows and darwin, however the only diffrence is in two binaries: ijar and singlejar.

This is part one: splitting java_tools and releasing split version (follows the use of split version in Bazel)

Java_tools used to be released for multiple Java versions, but all the releases were the same except a some string substitutions in BUILD file. I changed to build only a single version, since it already supports Java from 8 to 14.

Changes:
- BUILD.java_tools is split into BUILD.java_tools_prebuilt (where the second contains prebuilt binaries)
- toolchain definitions are removed from BUILD.java_tools and will be added to tools/jdk/BUILD in the second part
- java_toolchain_default.bzl.java_tools is removed (default_java_toolchain.bzl will be updated with its features in the second part).
- src/BUILD: JAVA_VERSION is removed, targets used to build java_tools.zip are duplicated to build java_tools_prebuilt.zip (done some cleanup as well)
- upload_all_java_tools.sh and upload_java_tools.sh: used by Build kite, I removed java_version over the release, but kept it over tests (for different JDKs)
- create_java_tools_release.sh: used by the user in the release process - added platform independent part
    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    8d7af86 View commit details
    Browse the repository at this point in the history

  2. Adding toolchain definitions to tools/jdk/BUILD.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    1280d6e View commit details
    Browse the repository at this point in the history

  3. Replacing prebuilt toolchains with rc1.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    a0c28c1 View commit details
    Browse the repository at this point in the history

  4. Added platform independent java_tools repo, removed javac11.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    f715188 View commit details
    Browse the repository at this point in the history

  5. Reenabling tests.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    9a627a9 View commit details
    Browse the repository at this point in the history

  6. Fixing checksums.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    20f5127 View commit details
    Browse the repository at this point in the history

  7. Fixing tests.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    2afb0f5 View commit details
    Browse the repository at this point in the history

  8. Fix default condition in //tools/jdk:singlejar_prebuilt_or_cc_binary

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    49fcfb5 View commit details
    Browse the repository at this point in the history

  9. Fix aliases in BUILD.java_langtools.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    c77cfec View commit details
    Browse the repository at this point in the history

  10. Fix aliases to point to filegroup not files in //tools/jdk/BUILD.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    26f7dfa View commit details
    Browse the repository at this point in the history

  11. Bumping java_tools release to rc2.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    0eff556 View commit details
    Browse the repository at this point in the history

  12. Bump java_tools to rc3.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    4bc2572 View commit details
    Browse the repository at this point in the history

  13. Release java_tools.

    @comius
    comius committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    c801a53 View commit details
    Browse the repository at this point in the history