Fix common prefix for instrumentation filter #12607
Conversation
In case that two path share a prefix, the instrumentation filter is not computed proper. bazelbuild#10949 This PR takes as a base the one that was created by @caiyulun and adds some tests. Original PR: bazelbuild#10949
| listOfTargets.add(getTarget("//foo:t")); | ||
| listOfTargets.add(getTarget("//foobar:t")); | ||
| Collection<Target> targets = Collections.unmodifiableCollection(listOfTargets); | ||
| String expectedFilter = "^//foo[/:],^//foobar[/:]"; |
There was a problem hiding this comment.
If prefered, I could split the PR in two commits to see more clear how the test would change with the changes.
Before the this PR the expected Filter would have been just ^//foo[/:]
There was a problem hiding this comment.
This is fine. We squash the PR into a single commit anyway, so there's limited value in splitting everything up incrementally in this case.
| listOfTargets.add(getTarget("//foo:t")); | ||
| listOfTargets.add(getTarget("//foobar:t")); | ||
| Collection<Target> targets = Collections.unmodifiableCollection(listOfTargets); | ||
| String expectedFilter = "^//foo[/:],^//foobar[/:]"; |
There was a problem hiding this comment.
This is fine. We squash the PR into a single commit anyway, so there's limited value in splitting everything up incrementally in this case.
|
@c-mita some checks are failing but looks more like an http error connection. |
|
@c-mita and me are merging this right now and I'll make sure to get it into Bazel 4.0.0rc3! :) |
In case that two path share a prefix, the instrumentation filter is not computed proper. bazelbuild#10949 This PR takes as a base the one that was created by @caiyulun and adds some tests. Original PR: bazelbuild#10949 Closes bazelbuild#12607. PiperOrigin-RevId: 346097533
In case that two path share a prefix, the instrumentation filter is
not computed proper.
#10949
This PR takes as a base the one that was created by @caiyulun and
adds some tests.
Original PR: #10949