Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when coveragerunner is not set on the toolchain. #12625

Closed
wants to merge 1 commit into from
Closed

Fix NPE when coveragerunner is not set on the toolchain. #12625

wants to merge 1 commit into from

Conversation

comius
Copy link
Contributor

@comius comius commented Dec 4, 2020 •
edited
Loading

Fixes #12619

@comius comius requested a review from lberki as a code owner December 4, 2020 07:42
@google-cla google-cla bot added the cla: yes label Dec 4, 2020
@comius comius requested review from jin and philwo and removed request for lberki December 4, 2020 07:43
@comius
Copy link
Contributor Author

comius commented Dec 4, 2020

I verified that this cleanly applies to 4.0.0 release baseline.

@comius comius self-assigned this Dec 4, 2020
@bazel-io bazel-io closed this in d90ec67 Dec 4, 2020
philwo pushed a commit that referenced this pull request Dec 7, 2020
@comius @philwo
Fix NPE when coveragerunner is not set on the toolchain.
8871166 
Fixes #12619

Closes #12625.

PiperOrigin-RevId: 345638551
philwo pushed a commit that referenced this pull request Dec 7, 2020
@comius @philwo
Fix NPE when coveragerunner is not set on the toolchain.
c859f32 
Fixes #12619

Closes #12625.

PiperOrigin-RevId: 345638551
philwo pushed a commit that referenced this pull request Dec 9, 2020
@comius @philwo
Fix NPE when coveragerunner is not set on the toolchain.
bd3fc11 
Fixes #12619

Closes #12625.

PiperOrigin-RevId: 345638551
philwo pushed a commit that referenced this pull request Dec 10, 2020
@comius @philwo
Fix NPE when coveragerunner is not set on the toolchain.
3b7f31e 
Fixes #12619

Closes #12625.

PiperOrigin-RevId: 345638551
ulfjack pushed a commit to EngFlow/bazel that referenced this pull request Mar 5, 2021
@comius @ulfjack
Fix NPE when coveragerunner is not set on the toolchain.
cc923ce 
Fixes bazelbuild#12619

Closes bazelbuild#12625.

PiperOrigin-RevId: 345638551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin jin jin approved these changes

@philwo philwo Awaiting requested review from philwo

Assignees

@comius comius

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java coverage crash on 4.0.0rc2
2 participants
@comius @jin