-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanitizer support to Apple platforms #12772
Add sanitizer support to Apple platforms #12772
Conversation
Yeah, this is generally fine. I'd note that we also set the following flags when any of the sanitizers are in use:
|
Would you recommend I add those here? I saw some flags in a previous PR that were similar, but I didn't want to add them w/o knowing if it was something that made sense generally or just for google |
I think they're generally useful. These two are recommended by the Clang ASan Usage docs:
For the other two:
YMMV |
This adds support for asan, tsan, and ubsan on Apple platforms. Fixes bazelbuild#4984 and bazelbuild#6932
e5d712c
to
8e51fdf
Compare
Fair enough! Added them here |
@trybka could you approve this PR? I'll import it as well. |
Thanks! |
This adds support for asan, tsan, and ubsan on Apple platforms.
Fixes #4984 and #6932